New issue
Advanced search Search tips

Issue 913668 link

Starred by 1 user
Status: Started
Owner:
mlamouri@chromium.org
Cc:
jazzhsu@chromium.org
steimel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocking:
issue 903793
issue 913671



Sign in to add a comment

Move cast overlay code out of media_controls

Project Member Reported by mlamouri@chromium.org, Dec 10 
Like other overlays, the cast overlay should not depend on the media controls being present.

This change will allow:
 - any part of Blink to be aware of remote playback status change
 - media controls to be properly created "on demand"
 - video wake lock to be released when remote playback starts

Comment 1 by mlamouri@chromium.org, Dec 10

Cc: jazzhsu@chromium.org steimel@chromium.org
+jazzhsu@ +steimel@ FYI as CLs may show up in your inbox :)

Comment 2 by mlamouri@chromium.org, Dec 10

Blocking: 913671
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdcad298bdbaccc6227d21f3ee0e64b346072548

commit cdcad298bdbaccc6227d21f3ee0e64b346072548
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Dec 12 21:18:34 2018

RemotePlayback: make RemotePlayback a HTMLMediaSupplement instead of bindings class.

HTMLMediaElementRemotePlayback (whith is HTMLMediaElement.remote) is
currently the supplement. Making RemotePlayback the supplement will
allow core/ to get the object and use it via an interface.

Bug: 913668
Change-Id: I8f2c1fb0039098d829d11b166191f6d4745eb96b
Reviewed-on: https://chromium-review.googlesource.com/c/1371215
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616045}
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/media_controls/elements/media_control_cast_button_element.cc
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/media_controls/media_controls_media_event_listener.cc
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/media_controls/media_controls_media_event_listener.h
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/modules_initializer.cc
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/remoteplayback/html_media_element_remote_playback.cc
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/remoteplayback/html_media_element_remote_playback.h
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/remoteplayback/remote_playback.cc
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/remoteplayback/remote_playback.h
[modify] https://crrev.com/cdcad298bdbaccc6227d21f3ee0e64b346072548/third_party/blink/renderer/modules/remoteplayback/remote_playback_test.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abd14b1e6a5fd4919e6b205342e929cfa122bd94

commit abd14b1e6a5fd4919e6b205342e929cfa122bd94
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu Dec 13 04:15:02 2018

Remote Playback: create Controller/Observer to allow core/ to be notified of changes.

This will allow the video wake lock implementation in Blink to change its
behaviour depending on remote playback state and will allow the remote
playback overaly to be moved out of modules/media_controls/

Bug: 913668, 903793
Change-Id: I473254b8108e612c52bdb55f4bd880ab0441922f
Reviewed-on: https://chromium-review.googlesource.com/c/1374951
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616208}
[modify] https://crrev.com/abd14b1e6a5fd4919e6b205342e929cfa122bd94/third_party/blink/renderer/core/html/BUILD.gn
[add] https://crrev.com/abd14b1e6a5fd4919e6b205342e929cfa122bd94/third_party/blink/renderer/core/html/media/remote_playback_controller.cc
[add] https://crrev.com/abd14b1e6a5fd4919e6b205342e929cfa122bd94/third_party/blink/renderer/core/html/media/remote_playback_controller.h
[add] https://crrev.com/abd14b1e6a5fd4919e6b205342e929cfa122bd94/third_party/blink/renderer/core/html/media/remote_playback_observer.h
[modify] https://crrev.com/abd14b1e6a5fd4919e6b205342e929cfa122bd94/third_party/blink/renderer/modules/remoteplayback/remote_playback.cc
[modify] https://crrev.com/abd14b1e6a5fd4919e6b205342e929cfa122bd94/third_party/blink/renderer/modules/remoteplayback/remote_playback.h
►

Sign in to add a comment