New issue
Advanced search Search tips

Issue 913662 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

CC should use Infinite to represent infinite iterations count

Project Member Reported by majidvp@chromium.org, Dec 10

Issue description

WebAnimations supports infinite iterations. In blink this is simply represented
by std::numeric_limits<double>::infinity() for iterations_count. This seems sensible enough.

However in cc animations we represent infinite iterations by -1 because historically iterations count was represented by an integer. This means trying to map the same time calculation algorithms between blink and cc requires extra mental gymnastic.


CC now uses double for iterations count. So we should use the same value to represent infinity.



[1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/animation/compositor_animations.cc?type=cs&sq=package:chromium&g=0&l=550
 
Summary: CC should use Infinite to represent infinite iterations count (was: CC iterations count should use Infinite to represent infinite count)
Labels: -Type-Bug Type-Task
Cc: yigu@chromium.org
Note: vr assumes the same and should be updated accordingly. 

Sign in to add a comment