New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 913659 link

Starred by 1 user
Status: Fixed
Owner:
█ tbergquist@chromium.org
Last visit > 30 days ago
Closed: Dec 18
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clean up tab_menu_model to use ICU syntax

Project Member Reported by tbergquist@google.com, Dec 10 
It is doing some weird manual pluralization stuff that can't be localized into languages with a different set of plural forms than English.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebe05dd688785eb8b86784e2f1a182325677e6d4

commit ebe05dd688785eb8b86784e2f1a182325677e6d4
Author: Taylor Bergquist <tbergquist@chromium.org>
Date: Tue Dec 18 19:58:33 2018

Make tab context menu strings use ICU syntax.

Bug:  913659 
Change-Id: I686f776bc7b9f6f959913871c62073790b529dd5
Reviewed-on: https://chromium-review.googlesource.com/c/1372914
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617599}
[modify] https://crrev.com/ebe05dd688785eb8b86784e2f1a182325677e6d4/chrome/app/generated_resources.grd
[modify] https://crrev.com/ebe05dd688785eb8b86784e2f1a182325677e6d4/chrome/browser/ui/tabs/tab_menu_model.cc

Comment 2 by tbergquist@chromium.org, Dec 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment