__main__.ChromeDriverTest.testTakeElementScreenshot and * __main__.ChromeDriverTest.testTakeElementScreenshotInIframe in chromedriver_py_tests failing on chromium.mac/Mac10.10 Tests |
|||
Issue descriptionLooks like it may be due to changes in: https://chromium-review.googlesource.com/c/1369037 More details in https://sheriff-o-matic.appspot.com/chromium/examine/chromium.mac.Mac10.10%20Tests.chromedriver_py_tests.
,
Dec 17
Taking a look...
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5be06c19e55ed417456b503df4e0b518ce53c310 commit 5be06c19e55ed417456b503df4e0b518ce53c310 Author: Yuri Wiitala <miu@chromium.org> Date: Tue Dec 18 02:07:29 2018 Disable ChromeDriverTest.testTakeElementScreenshot on Mac10.10. When pixel comparison fails on Mac OS X 10.10 (no other version), log an error message and allow a "free pass." This effectively is the same as disabling the test for just this specific Mac version. Bug: 913603 Change-Id: Ifc7b30a12d26d4f61059bd7da169543f6ce0209d Reviewed-on: https://chromium-review.googlesource.com/c/1380946 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#617344} [modify] https://crrev.com/5be06c19e55ed417456b503df4e0b518ce53c310/chrome/test/chromedriver/test/run_py_tests.py
,
Dec 18
,
Dec 18
Bug 897222 has attached graphics files that show the likely root cause of this bug. It seems, in a small number of test runs, the RHS vertical scrollbar is being captured in the image. In any case, the change in comment 3 has resolved the issue. Things have been consistently green for a while on the flakiness dashboard. |
|||
►
Sign in to add a comment |
|||
Comment 1 by fhorschig@chromium.org
, Dec 11