New issue
Advanced search Search tips

Issue 913597 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug-Regression


Show other hotlists

Hotlists containing this issue:
Autofill-Fixit


Sign in to add a comment

Autofill binary size growth is significant for M69->M72 (320kb)

Project Member Reported by agrieve@chromium.org, Dec 10

Issue description

Here's a sizes diff showing where the growth came from:

https://storage.googleapis.com/chrome-supersize/viewer.html?load_url=milestones%2Farm%2FMonochrome.apk%2Freport_69.0.3497.91_72.0.3626.7.ndjson&group_by=component&include=autofill&exclude=assets%2Funwind_cfi&diff_mode=on

For an increase of this size, we're generally looking for:
* Ways to significantly reduce, and/or
* Justification as to why the size hit is necessary & "worth it".

There are some tips here:
https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#step-2_analyze

But generally these investigations require specific deep-dives & some trial and error. Using the android-binary-size trybot, or locally running //tools/binary_size/diagnose_bloat.py can also help.

binary-size@chromium.org is also a list that exists for help with such things.
 
Cc: ma...@chromium.org se...@chromium.org gogerald@chromium.org
Components: UI>Browser>Autofill
Owner: ----
Thanks! Hoping to have a look soon.
Cc: rogerm@chromium.org
Roger posted a breakdown of this in our team chat back on Dec. 10th; it was mostly autofill_assistant, along with ongoing feature work (StrikeDatabase/LegacyStrikeDatabase) and a couple of related protos.
Is this feature launched?
If not, is it behind a GN arg so that we could disable it for beta & stable (we did this for feed, and are currently doing it for vulkan support)
Autofill Assistant is launching in M72. And we are considering to convert it to dynamic module.

Comment 5 by gogerald@chromium.org, Jan 18 (4 days ago)

Components: -UI>Browser>Autofill UI>Browser>Autofill>Assistant

Comment 6 by gogerald@chromium.org, Jan 18 (4 days ago)

Components: -UI>Browser>Autofill>Assistant UI>Browser>Autofill

Sign in to add a comment