Remove references to LASTCHANGE_STRING in chrome_cleaner_unittests |
|||
Issue descriptionPointed out by Nico at https://crrev.com/c/1160776/6/chrome/chrome_cleaner/logging/interface_log_service.cc#124, InterfaceLogService hardcodes LASTCHANGE_STRING in the log. LASTCHANGE_STRING is updated on every build, so every time this is built into a unit test, the test binary is different. That means test results can't be cached. We should pass inject a fixed version in tests, and only use LASTCHANGE_STRING in the final executables.
,
Dec 10
There are still some other uses of it in the internal repo that hasn't been upstreamed to chrome/chrome_cleaner yet. But I don't think our use of it is important enough to keep the entire mechanism around, so I'll clean those up as I upstream them.
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68fd9f0ca1c2084e32cc8f2f4742a64b337dd92a commit 68fd9f0ca1c2084e32cc8f2f4742a64b337dd92a Author: Joe Mason <joenotcharles@google.com> Date: Mon Dec 10 21:25:11 2018 Remove uses of LASTCHANGE in chrome_cleaner. R=proberge Bug: 913585 Change-Id: I42297b168d776767c56c83442df6eb3bed222e88 Reviewed-on: https://chromium-review.googlesource.com/c/1370401 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#615261} [modify] https://crrev.com/68fd9f0ca1c2084e32cc8f2f4742a64b337dd92a/chrome/chrome_cleaner/constants/BUILD.gn [modify] https://crrev.com/68fd9f0ca1c2084e32cc8f2f4742a64b337dd92a/chrome/chrome_cleaner/constants/args.gni [modify] https://crrev.com/68fd9f0ca1c2084e32cc8f2f4742a64b337dd92a/chrome/chrome_cleaner/constants/version.h.in [modify] https://crrev.com/68fd9f0ca1c2084e32cc8f2f4742a64b337dd92a/chrome/chrome_cleaner/logging/BUILD.gn [modify] https://crrev.com/68fd9f0ca1c2084e32cc8f2f4742a64b337dd92a/chrome/chrome_cleaner/logging/interface_log_service.cc [modify] https://crrev.com/68fd9f0ca1c2084e32cc8f2f4742a64b337dd92a/chrome/chrome_cleaner/logging/interface_log_service.h [modify] https://crrev.com/68fd9f0ca1c2084e32cc8f2f4742a64b337dd92a/chrome/chrome_cleaner/logging/interface_log_service_unittest.cc
,
Dec 10
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Dec 10