New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 913573 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-01-22
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

NTP background does not offer while offline

Project Member Reported by yyushkina@chromium.org, Dec 10

Issue description

Chrome Version: 70.0.3538.110

 
Screenshot 2018-11-30 at 6.00.09 PM.png
341 KB View Download
The issue is that the style is not reset if the background image fails to load. An onerror handler should be added (probably here): https://cs.chromium.org/chromium/src/chrome/browser/resources/local_ntp/local_ntp.js?l=377&rcl=b1d7623d787f9e04fa9d3373ecd628c9d2f27c56
I looked this a bit in crbug.com/851220. I think we need some refactoring of how the page loads/applies themes to various elements.
Labels: zine-triaged
NextAction: 2019-01-08
The NextAction date has arrived: 2019-01-08
Cc: kmilka@chromium.org
NextAction: 2019-01-22
Owner: gayane@chromium.org
Requires refactor of how theming is applied to local_ntp.js.

Gayane to look at this in context of themes + chrome colors. Update on the plan.
Labels: KR-Offline-Support O-Robust-NTP

Comment 8 by monor...@bugs.chromium.org, Today (19 hours ago)

The NextAction date has arrived: 2019-01-22

Sign in to add a comment