New issue
Advanced search Search tips

Issue 913565 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Add more MIME types to DownloadMimeTypeResult

Project Member Reported by eugenebut@google.com, Dec 10

Issue description

More than 40% of downloads are still categorized as "Other Type" and it
would be useful to limit that number to 20%.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1d7623d787f9e04fa9d3373ecd628c9d2f27c56

commit b1d7623d787f9e04fa9d3373ecd628c9d2f27c56
Author: Eugene But <eugenebut@google.com>
Date: Mon Dec 10 19:16:36 2018

Add more MIME types to DownloadMimeTypeResult.

More than 40% of downloads are still categorized as "Other Type" and it
would be useful to limit that number to 20%.

Large number of existing downloads are .zip, .exe, and .apk files, so
added other popular Archive formats as well as MacOS installer types.

The rest of files are just guesses of what the users can actually
download on the internet.

Bug:  913565 
Change-Id: Ia4556fa5d3cfc84b1d0191a1f74a0ef51ac17dfb
Reviewed-on: https://chromium-review.googlesource.com/c/1368654
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615196}
[modify] https://crrev.com/b1d7623d787f9e04fa9d3373ecd628c9d2f27c56/ios/chrome/browser/download/browser_download_service.h
[modify] https://crrev.com/b1d7623d787f9e04fa9d3373ecd628c9d2f27c56/ios/chrome/browser/download/browser_download_service.mm
[modify] https://crrev.com/b1d7623d787f9e04fa9d3373ecd628c9d2f27c56/tools/metrics/histograms/enums.xml

Labels: Merge-Request-72
Status: Fixed (was: Started)
This CL does not have any functional change, but simply adds a move values to an existing metric. We should be able to see the new data for DownloadMimeTypeResult on Canary tomorrow.
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 11

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faf80ba848b4d424ad932c9fe3a18953763f37ae

commit faf80ba848b4d424ad932c9fe3a18953763f37ae
Author: Eugene But <eugenebut@google.com>
Date: Tue Dec 11 21:08:50 2018

Add more MIME types to DownloadMimeTypeResult.

More than 40% of downloads are still categorized as "Other Type" and it
would be useful to limit that number to 20%.

Large number of existing downloads are .zip, .exe, and .apk files, so
added other popular Archive formats as well as MacOS installer types.

The rest of files are just guesses of what the users can actually
download on the internet.

TBR=eugenebut@google.com

(cherry picked from commit b1d7623d787f9e04fa9d3373ecd628c9d2f27c56)

Bug:  913565 
Change-Id: Ia4556fa5d3cfc84b1d0191a1f74a0ef51ac17dfb
Reviewed-on: https://chromium-review.googlesource.com/c/1368654
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615196}
Reviewed-on: https://chromium-review.googlesource.com/c/1372631
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#261}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/faf80ba848b4d424ad932c9fe3a18953763f37ae/ios/chrome/browser/download/browser_download_service.h
[modify] https://crrev.com/faf80ba848b4d424ad932c9fe3a18953763f37ae/ios/chrome/browser/download/browser_download_service.mm
[modify] https://crrev.com/faf80ba848b4d424ad932c9fe3a18953763f37ae/tools/metrics/histograms/enums.xml

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/faf80ba848b4d424ad932c9fe3a18953763f37ae

Commit: faf80ba848b4d424ad932c9fe3a18953763f37ae
Author: eugenebut@google.com
Commiter: eugenebut@chromium.org
Date: 2018-12-11 21:08:50 +0000 UTC

Add more MIME types to DownloadMimeTypeResult.

More than 40% of downloads are still categorized as "Other Type" and it
would be useful to limit that number to 20%.

Large number of existing downloads are .zip, .exe, and .apk files, so
added other popular Archive formats as well as MacOS installer types.

The rest of files are just guesses of what the users can actually
download on the internet.

TBR=eugenebut@google.com

(cherry picked from commit b1d7623d787f9e04fa9d3373ecd628c9d2f27c56)

Bug:  913565 
Change-Id: Ia4556fa5d3cfc84b1d0191a1f74a0ef51ac17dfb
Reviewed-on: https://chromium-review.googlesource.com/c/1368654
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615196}
Reviewed-on: https://chromium-review.googlesource.com/c/1372631
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#261}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment