R8 doesn't take -applymapping |
||
Issue descriptionRight now, R8 doesn't take applymapping with the comment: # TODO: R8 needs -applymapping equivalent. However it does support applymapping entirely and can be turned on.
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3d0df762a401d7e7bb7629e54981bab7871668b commit e3d0df762a401d7e7bb7629e54981bab7871668b Author: Egor Pasko <pasko@chromium.org> Date: Thu Jan 03 14:39:24 2019 Revert "Android: Turning on R8 instead of Proguard for public targets" This reverts commit 09f15bdb07cd457c1a96b08ce54faa4ba2771dee. Reason for revert: http://crbug.com/918796 Original change's description: > Android: Turning on R8 instead of Proguard for public targets > > We are in the process of migrating to R8 to replace Proguard. This is > the first step - move all usages of Proguard in public targets to R8. > > Some refactorings were natural with the few forced changes this caused. > > TBR=smaier > > Bug: 908988, 913554 > Change-Id: I2139919598fba1643d7560dc5557d5efb9a5887c > Reviewed-on: https://chromium-review.googlesource.com/c/1357306 > Reviewed-by: Sam Maier <smaier@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619471} TBR=wnwen@chromium.org,agrieve@chromium.org,smaier@chromium.org Change-Id: Ieb34a24da7c001e78d832f7300855c7c7c749add No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908988, 913554 Reviewed-on: https://chromium-review.googlesource.com/c/1394528 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#619634} [modify] https://crrev.com/e3d0df762a401d7e7bb7629e54981bab7871668b/build/android/gyp/proguard.py [modify] https://crrev.com/e3d0df762a401d7e7bb7629e54981bab7871668b/build/config/android/config.gni [modify] https://crrev.com/e3d0df762a401d7e7bb7629e54981bab7871668b/build/config/android/internal_rules.gni [modify] https://crrev.com/e3d0df762a401d7e7bb7629e54981bab7871668b/build/config/android/rules.gni [modify] https://crrev.com/e3d0df762a401d7e7bb7629e54981bab7871668b/chrome/android/BUILD.gn [modify] https://crrev.com/e3d0df762a401d7e7bb7629e54981bab7871668b/testing/android/proguard_for_test.flags [modify] https://crrev.com/e3d0df762a401d7e7bb7629e54981bab7871668b/third_party/accessibility_test_framework/proguard.flags
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a38b3ac1b4b8ea9781400d7efaef1bea94e65a82 commit a38b3ac1b4b8ea9781400d7efaef1bea94e65a82 Author: Egor Pasko <pasko@chromium.org> Date: Thu Jan 03 14:48:01 2019 Revert "Android: Turning on R8 instead of Proguard for public targets" This reverts commit 09f15bdb07cd457c1a96b08ce54faa4ba2771dee. Reason for revert: http://crbug.com/918796 Original change's description: > Android: Turning on R8 instead of Proguard for public targets > > We are in the process of migrating to R8 to replace Proguard. This is > the first step - move all usages of Proguard in public targets to R8. > > Some refactorings were natural with the few forced changes this caused. > > TBR=smaier > > Bug: 908988, 913554 > Change-Id: I2139919598fba1643d7560dc5557d5efb9a5887c > Reviewed-on: https://chromium-review.googlesource.com/c/1357306 > Reviewed-by: Sam Maier <smaier@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619471} TBR=wnwen@chromium.org,agrieve@chromium.org,smaier@chromium.org Change-Id: Ieb34a24da7c001e78d832f7300855c7c7c749add No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908988, 913554 Reviewed-on: https://chromium-review.googlesource.com/c/1394528 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#619634}(cherry picked from commit e3d0df762a401d7e7bb7629e54981bab7871668b) Reviewed-on: https://chromium-review.googlesource.com/c/1394647 Reviewed-by: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/branch-heads/3660@{#3} Cr-Branched-From: bd3d561129870953b32dfc6fef8a04604372d2ec-refs/heads/master@{#619561} [modify] https://crrev.com/a38b3ac1b4b8ea9781400d7efaef1bea94e65a82/build/android/gyp/proguard.py [modify] https://crrev.com/a38b3ac1b4b8ea9781400d7efaef1bea94e65a82/build/config/android/config.gni [modify] https://crrev.com/a38b3ac1b4b8ea9781400d7efaef1bea94e65a82/build/config/android/internal_rules.gni [modify] https://crrev.com/a38b3ac1b4b8ea9781400d7efaef1bea94e65a82/build/config/android/rules.gni [modify] https://crrev.com/a38b3ac1b4b8ea9781400d7efaef1bea94e65a82/chrome/android/BUILD.gn [modify] https://crrev.com/a38b3ac1b4b8ea9781400d7efaef1bea94e65a82/testing/android/proguard_for_test.flags [modify] https://crrev.com/a38b3ac1b4b8ea9781400d7efaef1bea94e65a82/third_party/accessibility_test_framework/proguard.flags
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36ab751f1a2b5777acff3d430fde3004c6ed1861 commit 36ab751f1a2b5777acff3d430fde3004c6ed1861 Author: Sam Maier <smaier@chromium.org> Date: Thu Jan 03 18:47:59 2019 Reland "Android: Turning on R8 instead of Proguard for public targets" This is a reland of 09f15bdb07cd457c1a96b08ce54faa4ba2771dee Original change's description: > Android: Turning on R8 instead of Proguard for public targets > > We are in the process of migrating to R8 to replace Proguard. This is > the first step - move all usages of Proguard in public targets to R8. > > Some refactorings were natural with the few forced changes this caused. > > TBR=smaier > > Bug: 908988, 913554 > Change-Id: I2139919598fba1643d7560dc5557d5efb9a5887c > Reviewed-on: https://chromium-review.googlesource.com/c/1357306 > Reviewed-by: Sam Maier <smaier@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619471} TBR=proguard.flags(smaier) Bug: 908988, 913554 Change-Id: I93690ad2a6838025221b7fab4b0bee1b06c920c9 Reviewed-on: https://chromium-review.googlesource.com/c/1394387 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#619702} [modify] https://crrev.com/36ab751f1a2b5777acff3d430fde3004c6ed1861/build/android/gyp/proguard.py [modify] https://crrev.com/36ab751f1a2b5777acff3d430fde3004c6ed1861/build/config/android/config.gni [modify] https://crrev.com/36ab751f1a2b5777acff3d430fde3004c6ed1861/build/config/android/internal_rules.gni [modify] https://crrev.com/36ab751f1a2b5777acff3d430fde3004c6ed1861/build/config/android/rules.gni [modify] https://crrev.com/36ab751f1a2b5777acff3d430fde3004c6ed1861/chrome/android/BUILD.gn [modify] https://crrev.com/36ab751f1a2b5777acff3d430fde3004c6ed1861/testing/android/proguard_for_test.flags [modify] https://crrev.com/36ab751f1a2b5777acff3d430fde3004c6ed1861/third_party/accessibility_test_framework/proguard.flags |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 2