New issue
Advanced search Search tips

Issue 913523 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

🍏Chevron is incorrect

Project Member Reported by noyau@google.com, Dec 10

Issue description

In recent tabsa chevron on closed rows should be > not ^. 

 
Cc: pschaffner@chromium.org
Owner: sczs@chromium.org
Status: Assigned (was: Unconfirmed)
Sergio, can you take a look at this history bug?

cc'ing Pete since this will likely need new assets.
Status: Started (was: Assigned)
No new assets are needed since we rotate the one we have. I created to fix this 
https://crrev.com/c/1385284
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a77436692693d3ab9024adc18d8954cf19bf817

commit 4a77436692693d3ab9024adc18d8954cf19bf817
Author: sczs <sczs@chromium.org>
Date: Thu Dec 20 16:29:47 2018

[ios] Changes Recent Tabs Chevron direction and Cell Text Color

- Changes the direction of the Chevron for collapsed sections on Recent Tabs
from ^ to >
- Changes the Show Full History cell text color to blue.

Screenshots:
https://drive.google.com/open?id=10nWzEHY5-I0MPsr93RkckIN3j3GoKVCz
https://drive.google.com/open?id=1s_M1YnTLysIK7GJSYJBr7hQl0AptbIvF
https://drive.google.com/open?id=1eL6pIBdhsOC3_4LJ4cnXNXegbxnPvyJ2

Bug:  913523 
Change-Id: Ic788398c60cef39c3c2d72f4ef4a9f6859141d66
Reviewed-on: https://chromium-review.googlesource.com/c/1385284
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618236}
[modify] https://crrev.com/4a77436692693d3ab9024adc18d8954cf19bf817/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
[modify] https://crrev.com/4a77436692693d3ab9024adc18d8954cf19bf817/ios/chrome/browser/ui/table_view/cells/table_view_disclosure_header_footer_item.h
[modify] https://crrev.com/4a77436692693d3ab9024adc18d8954cf19bf817/ios/chrome/browser/ui/table_view/cells/table_view_disclosure_header_footer_item.mm
[modify] https://crrev.com/4a77436692693d3ab9024adc18d8954cf19bf817/ios/chrome/browser/ui/table_view/cells/table_view_image_item.h
[modify] https://crrev.com/4a77436692693d3ab9024adc18d8954cf19bf817/ios/chrome/browser/ui/table_view/cells/table_view_image_item.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on 73.0.3665.0 Canary,  iPhoneXR  iOS 12.1.2
Looks good
https://drive.google.com/file/d/1nXMzQUDmLDUXYQtPMWaMHaqDjsUZ1jJ_/view?usp=sharing

Sign in to add a comment