New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 913515 link

Starred by 2 users
Status: Assigned
Owner:
jperaza@chromium.org
Cc:
szager@chromium.org
yhirano@chromium.org
█ ramyan@chromium.org
mamir@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

org.chromium.android_webview.test.AwDebugTest has 3 failed tests for "Android CFI "

Project Member Reported by hua...@chromium.org, Dec 10 
The tests

  org.chromium.android_webview.test.AwDebugTest#testDumpDoesNotContainNonWhitelistedKey
  org.chromium.android_webview.test.AwDebugTest#testDump
  org.chromium.android_webview.test.AwDebugTest#testDumpContainsWhitelistedKey

Have been failing on Android CFI, starting from either of

  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3897
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3898

The main suspect is

  https://chromium-review.googlesource.com/c/chromium/src/+/1357941

A revert CL was made previously last week by the author, but never sent out:

  https://chromium-review.googlesource.com/c/chromium/src/+/1361286

but now has merge conflict.

Comment 1 by hua...@chromium.org, Dec 10 

Going to disable the tests to denoise the system.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fce879b44c0be70da8d2620c8ee49130c51c66c9

commit fce879b44c0be70da8d2620c8ee49130c51c66c9
Author: Samuel Huang <huangs@chromium.org>
Date: Mon Dec 10 17:26:50 2018

[Sheriff] Disable 3 tests from org.chromium.android_webview.test.AwDebugTest

The following tests have been consistently failing on "Android CFI":

  org.chromium.android_webview.test.AwDebugTest#testDump
  org.chromium.android_webview.test.AwDebugTest#testDumpContainsWhitelistedKey
  org.chromium.android_webview.test.AwDebugTest#testDumpDoesNotContainNonWhitelistedKey

Culprit is likely
  https://chromium-review.googlesource.com/c/chromium/src/+/1357941
but revert is likey painful, as seen in
  https://chromium-review.googlesource.com/c/chromium/src/+/1361286

This CL disables the test to denoise the system.

Tbr: jperaza@chromium.org
Bug: 913515
Change-Id: Ia62b796067294920164cfd37f662f40e467b2d07
Reviewed-on: https://chromium-review.googlesource.com/c/1370191
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615157}
[modify] https://crrev.com/fce879b44c0be70da8d2620c8ee49130c51c66c9/android_webview/javatests/src/org/chromium/android_webview/test/AwDebugTest.java
►

Sign in to add a comment