New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 913490 link

Starred by 1 user
Status: Duplicate
Merged: issue 913181
Owner:
ccameron@chromium.org
Closed: Dec 10
Cc:
szager@chromium.org
yhirano@chromium.org
█ ramyan@chromium.org
mamir@chromium.org
mac-bugs-priority@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

AppShimInteractiveTest.Launch flaky on "Mac10.10 Tests"

Project Member Reported by hua...@chromium.org, Dec 10 
On the "Mac10.10 Tests":

  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests?limit=200

AppShimInteractiveTest.Launch is flaky since:

  2018-12-07 11:29 PM (EST)	28 mins 25 secs	9391f2b417978dcf506b06b153e3bbfbbb319e2b	Failed	37101

Cause appears to be:

  https://chromium-review.googlesource.com/c/chromium/src/+/1364220

A CL appears to be in progress to fix this

  https://chromium-review.googlesource.com/c/chromium/src/+/1369136

Comment 1 by hua...@chromium.org, Dec 10 

Going to disable the test rather than reverting, to reduce impact.

https://chromium-review.googlesource.com/c/chromium/src/+/1369721
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c873bf2265189967d77b2cbccee70cfd14e9db9

commit 0c873bf2265189967d77b2cbccee70cfd14e9db9
Author: Samuel Huang <huangs@chromium.org>
Date: Mon Dec 10 17:29:20 2018

[Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness.

Tbr: ccameron@chromium.org
Bug:  913490 
Change-Id: I90fabcfe3bba129fbe2786738c3757526b423a6f
Reviewed-on: https://chromium-review.googlesource.com/c/1369721
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615159}
[modify] https://crrev.com/0c873bf2265189967d77b2cbccee70cfd14e9db9/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

Comment 3 by hua...@chromium.org, Dec 10

Mergedinto: 913181
Status: Duplicate (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00c1b7ab0080db58436431b6dbe1956b2457abbc

commit 00c1b7ab0080db58436431b6dbe1956b2457abbc
Author: ccameron <ccameron@chromium.org>
Date: Mon Dec 10 22:02:27 2018

Revert "[Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness."

This reverts commit 0c873bf2265189967d77b2cbccee70cfd14e9db9.

Reason for revert: Fix for flake in crrev.com/615269

Original change's description:
> [Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness.
> 
> Tbr: ccameron@chromium.org
> Bug:  913490 
> Change-Id: I90fabcfe3bba129fbe2786738c3757526b423a6f
> Reviewed-on: https://chromium-review.googlesource.com/c/1369721
> Commit-Queue: Samuel Huang <huangs@chromium.org>
> Reviewed-by: Samuel Huang <huangs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615159}

TBR=huangs@chromium.org,ccameron@chromium.org

Change-Id: I1326fab24c9d4d85bbd66b8b48b60f8471b86593
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  913490 
Reviewed-on: https://chromium-review.googlesource.com/c/1370571
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615274}
[modify] https://crrev.com/00c1b7ab0080db58436431b6dbe1956b2457abbc/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/541c2952f6896bdc75d2151153cb4dfa83b42646

commit 541c2952f6896bdc75d2151153cb4dfa83b42646
Author: ccameron <ccameron@chromium.org>
Date: Tue Dec 11 17:28:47 2018

Reland "[Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness."

This reverts commit 00c1b7ab0080db58436431b6dbe1956b2457abbc.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "[Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness."
> 
> This reverts commit 0c873bf2265189967d77b2cbccee70cfd14e9db9.
> 
> Reason for revert: Fix for flake in crrev.com/615269
> 
> Original change's description:
> > [Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness.
> > 
> > Tbr: ccameron@chromium.org
> > Bug:  913490 
> > Change-Id: I90fabcfe3bba129fbe2786738c3757526b423a6f
> > Reviewed-on: https://chromium-review.googlesource.com/c/1369721
> > Commit-Queue: Samuel Huang <huangs@chromium.org>
> > Reviewed-by: Samuel Huang <huangs@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#615159}
> 
> TBR=huangs@chromium.org,ccameron@chromium.org
> 
> Change-Id: I1326fab24c9d4d85bbd66b8b48b60f8471b86593
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  913490 
> Reviewed-on: https://chromium-review.googlesource.com/c/1370571
> Reviewed-by: ccameron <ccameron@chromium.org>
> Commit-Queue: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#615274}

TBR=huangs@chromium.org,ccameron@chromium.org

Change-Id: I72829b7b404a571095123f2ffd028ff189563ee8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  913490 
Reviewed-on: https://chromium-review.googlesource.com/c/1371931
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615570}
[modify] https://crrev.com/541c2952f6896bdc75d2151153cb4dfa83b42646/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
►

Sign in to add a comment