New issue
Advanced search Search tips

Issue 913489 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make WebApkTestHelper capable of registering WebAPKs with share targets

Project Member Reported by pkotw...@chromium.org, Dec 10

Issue description

Make WebApkTestHelper capable of registering WebAPKs with share targets
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f509bd1b8f4a9eacab5414fa622a500247975bea

commit f509bd1b8f4a9eacab5414fa622a500247975bea
Author: Peter Kotwicz <pkotwicz@chromium.org>
Date: Thu Dec 13 03:08:29 2018

[Android WebAPK]: Add test for WebAPK share target updates

This CL:
- Adds a test to check that an update is requested when the
share target in the Web Manifest is updated.
- Adds parameter to WebApkTestHelper#register() to register a WebAPK
  with share targets
- Refactors WebApkShareTargetUtilTest to register share targets via
  WebApkTestHelper

BUG= 913489 

Change-Id: Ie8244f62e9c9855e97324591abfaaefb3421d420
Reviewed-on: https://chromium-review.googlesource.com/c/1369525
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616188}
[modify] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/chrome/android/junit/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationUnitTest.java
[modify] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInfoTest.java
[modify] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkShareTargetUtilTest.java
[modify] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkUpdateManagerUnitTest.java
[modify] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/chrome/android/webapk/libs/client/junit/src/org/chromium/webapk/lib/client/WebApkIdentityServiceClientTest.java
[modify] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/HostBrowserUtilsTest.java
[modify] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
[modify] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/chrome/android/webapk/test/src/org/chromium/webapk/test/WebApkTestHelper.java
[modify] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/testing/android/junit/BUILD.gn
[add] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/testing/android/junit/java/src/org/chromium/testing/local/CustomShadowApplicationPackageManager.java
[modify] https://crrev.com/f509bd1b8f4a9eacab5414fa622a500247975bea/testing/android/junit/java/src/org/chromium/testing/local/LocalRobolectricTestRunner.java

Status: Fixed (was: Started)

Sign in to add a comment