New issue
Advanced search Search tips

Issue 913480 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 13
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 913477



Sign in to add a comment

Support the ServiceManager only mode in NativeBackgroundTask

Project Member Reported by hanxi@chromium.org, Dec 10

Issue description

NativeBackgroundTask is the superclass of all of the BackgroundTasks that require native code to be loaded. NativeBackgroundTask#runWithNative() creates a new EmptyBrowserParts which initializes the native code. We want the NativeBackgroundTask overrides the BrowserParts#startServiceManagerOnly() when creating the EmptyBrowserParts. The return value of startServiceManagerOnly() comes from whether a background task supports running in the ServiceManager only mode.
 
Labels: OS-Android
Owner: mheikal@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0d0b53a5d0f521274e90a1619810f447e538d52

commit d0d0b53a5d0f521274e90a1619810f447e538d52
Author: Mohamed Heikal <mheikal@chromium.org>
Date: Wed Dec 12 17:13:51 2018

Allow NativeBackgrounTask to start in ServiceManagerOnly mode

NativeBackgroundTask now allows subclasses to indicate if they support
lite mode. If they do, the EmptyBrowserParts that it creates would also
signal the same to native.

Bug:  913480 
Change-Id: I85bf27e9edd5b01cee7756c7a951cd95d3e9520e
Reviewed-on: https://chromium-review.googlesource.com/c/1370580
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615932}
[modify] https://crrev.com/d0d0b53a5d0f521274e90a1619810f447e538d52/chrome/android/java/src/org/chromium/chrome/browser/background_task_scheduler/NativeBackgroundTask.java

Can this be considered fixed?
Status: Fixed (was: Assigned)
Marked it as fixed.

Sign in to add a comment