New issue
Advanced search Search tips

Issue 913435 link

Starred by 1 user
Status: Available
Owner:
thakis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 913434
Blocking:
issue 872407



Sign in to add a comment

Try making webkit_version.h not generated

Project Member Reported by thakis@chromium.org, Dec 10 
webkit_version.h contains three defines: WEBKIT_VERSION_MAJOR, WEBKIT_VERSION_MINOR, and WEBKIT_SVN_REVISION. The former two are frozen in time, and the third is mostly used only for devtools for…something (issue 913434). If we can remove uses of WEBKIT_SVN_REVISION, we can make this a non-generated file.

(which then removes one dep on lastchange)
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbf379905ae51525552ddc195fffc8b8341f3533

commit fbf379905ae51525552ddc195fffc8b8341f3533
Author: Nico Weber <thakis@chromium.org>
Date: Mon Dec 10 23:30:13 2018

[Chrome OS]: Stop showing Blink revision on the detailed build info page.

The Blink revision has been identical to the regular Chromium revision for
a few years now.

Bug:  546841 ,913435
Change-Id: I10736896c2b912454d4e2ddfe0479da49ea6a2f0
Reviewed-on: https://chromium-review.googlesource.com/c/1369629
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615315}
[modify] https://crrev.com/fbf379905ae51525552ddc195fffc8b8341f3533/chrome/browser/resources/settings/about_page/detailed_build_info.html
[modify] https://crrev.com/fbf379905ae51525552ddc195fffc8b8341f3533/chrome/browser/ui/webui/settings/about_handler.cc

Comment 2 by chrishtr@chromium.org, Dec 12

Components: -Blink Blink>Infra
►

Sign in to add a comment