WebRTC AGC2 VAD classification errors |
||||||
Issue descriptionChrome Version: All OS: All What steps will reproduce the problem? (1) Start a WebRTC call with AGC2 in a noisy environment. (2) Stay silent for 1-2 minutes. What is the expected result? Noise volume at the other end remains low. What happens instead? Noise volume is raised to almost full-scale.
,
Dec 10
Requesting merge for M72. It's a minimal change and the code runs behind a Finch experiment (WebRtcHybridAgc). The change consists of a new tuning and is covered by a kill switch. It's not yet in canary, but will be out in the next one (I think 73.0.3637.0). Given that the code change is behind a finch experiment and a kill switch, we consider this merge to be safe.
,
Dec 10
Thans aleloi@ - let's confirm this tomorrow in canary first, and then we can merge review this tomorrow.
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a28a6097182e739c4a8c600b538fcc07681fc7a3 commit a28a6097182e739c4a8c600b538fcc07681fc7a3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 18:55:42 2018 Roll src/third_party/webrtc 24d8ec3dbb2a..69540f44196e (2 commits) https://webrtc.googlesource.com/src.git/+log/24d8ec3dbb2a..69540f44196e git log 24d8ec3dbb2a..69540f44196e --date=short --no-merges --format='%ad %ae %s' 2018-12-10 artit@webrtc.org Use android Nullable instead of javax Nullable 2018-12-10 aleloi@webrtc.org Re-tuning of VAD in AGC2. Created with: gclient setdep -r src/third_party/webrtc@69540f44196e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG= chromium:771683 , chromium:913430 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I81441701fbdccb566d5422f9c6efafe66b9a1931 Reviewed-on: https://chromium-review.googlesource.com/c/1370284 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615190} [modify] https://crrev.com/a28a6097182e739c4a8c600b538fcc07681fc7a3/DEPS
,
Dec 11
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11
aleloi@ please confirm if tests on canary are looking good so we can review/approve merge for M72
,
Dec 12
aleloi@ any update on canary results
,
Dec 13
Yes, srinivassista@, everything fine on Canary. The change is in 73.0.3637.0.
,
Dec 13
approving the change for M72 Branch :3626
,
Dec 17
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 21
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 8
Did this get merged?
,
Jan 11
Yes, it got merged. Removing the label. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Dec 10