nocompile tests don't respect the clang_base_path gn flag |
||
Issue descriptionThe clang_base_path gn flag is used to tell the build system where to find clang. This is useful when testing new clang versions. However, the nocompile tests don't seem to respect that flag, making it harder to reproduce test failures with new clang versions (see crbug.com/912021 ). It would be great if the nocompile tests were set up to respect this flag and invoke the same compiler as the rest of the build.
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8261b16886d3c7732fd2a87a74b32f7263d290ed commit 8261b16886d3c7732fd2a87a74b32f7263d290ed Author: Hans Wennborg <hans@chromium.org> Date: Mon Jan 14 13:40:16 2019 Make nocompile tests respect clang_base_path This will help reproducing nocompile test failures with locally built Clang, and also fixes a TODO from 2011 :-) Bug: 913420 Change-Id: I613f0836d92c8f3f6513e0e03af83206447e4c76 Reviewed-on: https://chromium-review.googlesource.com/c/1409188 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#622440} [modify] https://crrev.com/8261b16886d3c7732fd2a87a74b32f7263d290ed/build/nocompile.gni [modify] https://crrev.com/8261b16886d3c7732fd2a87a74b32f7263d290ed/tools/nocompile_driver.py
,
Jan 14
|
||
►
Sign in to add a comment |
||
Comment 1 by h...@chromium.org
, Jan 14