Non-Regression : Unnecessarily App name and apps are seen outside of the folder and overlapped with shelf when Display is changed to 'Huge' Size |
||||
Issue descriptionChrome Version: 73.0.3635.0/11378.0.0 dev channel Kip,Daisy and Reks OS: Chrome What steps will reproduce the problem? 1)Sign into User ->Go to chrome://settings/display -> At 'Internal Display' select High resolution(To 'Huge' , then resolution will be 911 * 512) 2)Now click on App Launcher -> click on More Items ->Open App folder which is created with 20-22 apps(so that next page in Folder will be created) -> now observe App name and apps are seen outside of the folder and overlapped with shelf i.e.Apps should available within folder and should be able to scroll (Please refer Video and Screenshot) Expected: App name and apps are should available within folder and should not overlapped with shelf Actual: Instead App name and apps are seen outside of the folder and overlapped with shelf This is Non-Regression Issue seen from M-71 Note : In M-70 Apps are seen inside the folder but unable to scroll
,
Dec 12
,
Jan 14
+sgabriel@, could we make the folder scrollable with a scrollbar to solve the issue?
,
Jan 14
Another possible solution could be scaling down the folder to fit in screen?
,
Jan 16
This is what we discussed at my desk correct? I believe we'll do the same thing as the launcher, scale down the icons.
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfd90688ae6be060fae2ae14fcbaad17b8728843 commit cfd90688ae6be060fae2ae14fcbaad17b8728843 Author: Weidong Guo <weidongg@chromium.org> Date: Thu Jan 17 18:28:01 2019 Fix folder issue in small display Changes: 1. Instead of apply transform to apps grid, apply it to the AppListMainView when apps grid does not fit in small display. 2. Add a separate layer for AppListMainView. 3. Avoid converting point using transform by using local coordiates when calculating the page flip buffer and bottom drag buffer. 4. Clean up unused code. Images: https://screenshot.googleplex.com/XcFxsGn9wfJ https://screenshot.googleplex.com/JkvuTu9FoZY https://screenshot.googleplex.com/Yy6OZfD4NvL Bug: 914509 , 913408 Change-Id: I2030e865b1da26f23940f64454ba7ce514e0e5cf Reviewed-on: https://chromium-review.googlesource.com/c/1413136 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#623760} [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/app_list_main_view.cc [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/apps_container_view.cc [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/apps_container_view.h [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/apps_grid_view.cc [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/apps_grid_view.h [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/contents_view.cc [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/contents_view.h [modify] https://crrev.com/cfd90688ae6be060fae2ae14fcbaad17b8728843/ash/app_list/views/horizontal_page_container.cc
,
Jan 17
(5 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by newcomer@google.com
, Dec 10