Mac PWAs: Print has Command-P label in 3 dot menu but that keyboard accelerator isn't mapped |
|||
Issue descriptionMinor polish issue: the 3-dot menu in Mac PWAs has the Command-P label next to it, but that shortcut isn't actually hooked up (see attached). We should either hook up the keyboard accelerator, or remove the label with the accelerator. Probably doesn't need to block M73.
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/366ad8ea07e50ff199ceea5396066d7946c960c3 commit 366ad8ea07e50ff199ceea5396066d7946c960c3 Author: Christopher Cameron <ccameron@chromium.org> Date: Tue Dec 11 22:34:53 2018 RemoteMacViews: Re-enable print menu item in PWA mode Leave the "print using system dialog" item (which appears when one presses option) disabled, because that interface appears in the Chrome process (instead of the app process). Bug: 913396 Change-Id: Ifd5715d68fbc532533834b869a1931ed3a48237d Reviewed-on: https://chromium-review.googlesource.com/c/1371941 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#615697} [modify] https://crrev.com/366ad8ea07e50ff199ceea5396066d7946c960c3/chrome/browser/ui/cocoa/main_menu_builder.mm
,
Dec 14
,
Jan 14
Issue 550326 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by ccameron@chromium.org
, Dec 10