New issue
Advanced search Search tips

Issue 913393 link

Starred by 3 users
Status: Fixed
Owner:
toniki...@chromium.org
Closed: Dec 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318
issue 883330



Sign in to add a comment

Convert inline_login_ui_browsertest.cc to use IdentityTestEnvironment rather than FakePO2TS/FakeSigninManager

Project Member Reported by blundell@chromium.org, Dec 10 
If this is too unwieldy to do in one go, could do it incrementally by using the IdentityTestEnvironment constructor where it takes in its dependencies and then successively replacing usage of PO2TS/SigninManager.

Comment 1 by toniki...@chromium.org, Dec 20

Owner: toniki...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bb4fe62b9544da7e0ccb4c3ac469fc628277018

commit 4bb4fe62b9544da7e0ccb4c3ac469fc628277018
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Thu Dec 20 17:19:04 2018

[s13n] Convert inline_login_ui_browsertest.cc away from FakePO2TS/FakeSigninManager

CL uses IdentityTestEnvProfileAdaptor and IdentityManager directly when application,
as replacement of SigninManager and PO2TS.

BUG= 913393 

Change-Id: Iaafac731c8681f8c248a8777eb11b2d5d7df0461
Reviewed-on: https://chromium-review.googlesource.com/c/1387125
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#618254}
[modify] https://crrev.com/4bb4fe62b9544da7e0ccb4c3ac469fc628277018/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc

Comment 4 by toniki...@chromium.org, Dec 20

Status: Fixed (was: Started)
►

Sign in to add a comment