New issue
Advanced search Search tips

Issue 913388 link

Starred by 3 users
Status: Fixed
Owner:
svil...@igalia.com
Closed: Dec 22
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883318
issue 883330



Sign in to add a comment

Port browsing_history_handler_unittest.cc to use IdentityTestEnvironment

Project Member Reported by blundell@chromium.org, Dec 10 
Something to first verify is that the fakes of PO2TS/SigninManager even need to be injected in the first place. The test does not interact with them directly AFAICT. (i.e., first try just removing their injection and see whether the tests still pass).

Comment 1 by svil...@igalia.com, Dec 20

Owner: svil...@igalia.com
Status: Started (was: Available)
Taking this
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70c713c45afb4ab477fcf11a983f3af326a73d80

commit 70c713c45afb4ab477fcf11a983f3af326a73d80
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Fri Dec 21 11:21:21 2018

Port browsing_history_handler_unittest.cc to identity APIs

It turns out that it's enough to remove the dependencies with
ProfileOAuth2TokenService and SigninManager as they are not really
needed, so nothing else needs to be migrated.

Bug:  913388 
Change-Id: I4d6b462056cfd515b8b413cb5b07fc7019d9b1d7
Reviewed-on: https://chromium-review.googlesource.com/c/1386831
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#618498}
[modify] https://crrev.com/70c713c45afb4ab477fcf11a983f3af326a73d80/chrome/browser/ui/webui/browsing_history_handler_unittest.cc

Comment 3 by svil...@igalia.com, Dec 22

Status: Fixed (was: Started)
►

Sign in to add a comment