Issue metadata
Sign in to add a comment
|
Regression: File name and Save button fields are seen disabled when we try to save any page in File Manager |
||||||||||||||||||||||
Issue descriptionChrome Version:73.0.3635.0/11378.0.0 dev channel Daisy,Kip,Reks OS: chrome OS What steps will reproduce the problem? (1)Sign into user >> Launch chrome,take print preview of any page >> click save and observe Actual: File name and Save button fields are seen disabled in Save page overlay Expected:File name and Save button fields should be seen enabled when a page is saved. This is a Regression issue as same works fine in 73.0.3628.0/11330.0.0 dev Attached the screencast for reference..
,
Dec 10
Repo'd - forground console error logs:
_createLocalRoot @ polymer-mini-extracted.js:2083
main_scripts.js:71 [unhandled-error]: TypeError: Cannot read property 'createReader' of null
Error: original stack
at console.error.args [as error] (chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js:68:19)
at window.addEventListener (chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/foreground/js/main_scripts.js:51:11)
console.error.args @ main_scripts.js:71
main_scripts.js:13868 Uncaught (in promise) TypeError: Cannot read property 'createReader' of null
at VolumeEntry.createReader (main_scripts.js:13868)
at HTMLDivElement.EntryListItem.updateSubDirectories (main_scripts.js:43431)
at HTMLUnknownElement.DirectoryTree.updateSubElementsFromList (main_scripts.js:44459)
at HTMLUnknownElement.DirectoryTree.redraw (main_scripts.js:44650)
at HTMLUnknownElement.DirectoryTree.onFilterChanged_ (main_scripts.js:44662)
at FileFilter.dispatchEvent (main_scripts.js:2983)
at Object.dispatchSimpleEvent (main_scripts.js:1625)
at FileFilter.addFilter (main_scripts.js:21928)
at DialogActionController.onFileTypeFilterChanged_ (main_scripts.js:21343)
at new DialogActionController (main_scripts.js:21045)
44main_scripts.js:10500 Uncaught TypeError: command.matchesEvent is not a function
at CommandManager.handleKeyDown_ (main_scripts.js:10500)
,
Dec 10
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b0688262b28a8d9a674e3d86059e87612c17ff4 commit 8b0688262b28a8d9a674e3d86059e87612c17ff4 Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Dec 11 01:25:56 2018 Fix VolumeEntry createReader when root entry isn't resolved Bug: 913375 Change-Id: Ic147f0523c0183f4ede2c536d60095d6a5ff08be Reviewed-on: https://chromium-review.googlesource.com/c/1370227 Reviewed-by: Stuart Langley <slangley@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#615365} [modify] https://crrev.com/8b0688262b28a8d9a674e3d86059e87612c17ff4/ui/file_manager/file_manager/common/js/files_app_entry_types.js [modify] https://crrev.com/8b0688262b28a8d9a674e3d86059e87612c17ff4/ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
,
Dec 11
,
Dec 13
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by slangley@chromium.org
, Dec 10