New issue
Advanced search Search tips

Issue 913369 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Non-Regression: Play button is seen enabled when there is no text for preview in chrome://settings/manageAccessibility/tts

Project Member Reported by rkalavakuntla@chromium.org, Dec 10

Issue description

Chrome Version:73.0.3635.0/11378.0.0 dev channel Daisy,Kip,Reks
OS: chrome OS

What steps will reproduce the problem?
(1)Sign into user >>Navigate to chrome://settings/manageAccessibility/tts
(2)In Text to preview text box,remove the entire text and observe the 'Play' button

Actual:Play button is seen enabled when there is no text for preview
Expected:Play button should be seen disabled when there is no text for preview

This is a Non-Regression issue seen from M69

NOTE: Issue is seen on M70 and M71

Attaching screencast for reference..
 




 
Actual.jpg
2.2 MB View Download
Actual.mp4
7.2 MB View Download
Owner: katie@chromium.org
Status: Assigned (was: Untriaged)
Want to take this on?
Labels: -Pri-2 Pri-3
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0805f3921358a5fc3483e5157a17c3e4cc2869cb

commit 0805f3921358a5fc3483e5157a17c3e4cc2869cb
Author: Katie D <katie@chromium.org>
Date: Fri Dec 21 00:00:06 2018

Disable the TTS preview play button when only whitespace is entered.

Also changes 'let' to 'const' per new git cl presubmit error.

Bug:  913369 
Change-Id: I922ccccb6425a680f6da30200c8f0535fbd2daff
Reviewed-on: https://chromium-review.googlesource.com/c/1376094
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618391}
[modify] https://crrev.com/0805f3921358a5fc3483e5157a17c3e4cc2869cb/chrome/browser/resources/settings/a11y_page/tts_subpage.html
[modify] https://crrev.com/0805f3921358a5fc3483e5157a17c3e4cc2869cb/chrome/browser/resources/settings/a11y_page/tts_subpage.js

Status: Fixed (was: Started)

Sign in to add a comment