New issue
Advanced search Search tips

Issue 913319 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile exif_parser_unittest

Project Member Reported by noel@chromium.org, Dec 10

Issue description

- remove the current html unittest
- closure compile the code and the unittest



 
Owner: noel@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0772ee7afd867747f09851c3e4de837bb267cdca

commit 0772ee7afd867747f09851c3e4de837bb267cdca
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 10 08:19:05 2018

Closure compile exif_parser_unittest

 - remove exif_parser_unittest.html
 - add BUILD rules to auto-generate and compile the code
 - add pre-amble test script re-loader to avoid unittest
   run-time exceptions when the unittest starts
 - fix Closure compile errors and format the JS code

No change in test behavior.

Bug:  913319 
Change-Id: Id4dbd8022ca8492d0937b9d8a3ba559790c28c2c
Reviewed-on: https://chromium-review.googlesource.com/c/1369491
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615067}
[modify] https://crrev.com/0772ee7afd867747f09851c3e4de837bb267cdca/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/0772ee7afd867747f09851c3e4de837bb267cdca/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[delete] https://crrev.com/43558d886bc744212ce6eaf854fb87d6eec440b9/ui/file_manager/file_manager/foreground/js/metadata/exif_parser_unittest.html
[modify] https://crrev.com/0772ee7afd867747f09851c3e4de837bb267cdca/ui/file_manager/file_manager/foreground/js/metadata/exif_parser_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment