New issue
Advanced search Search tips

Issue 913312 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile directory_model_unittest

Project Member Reported by noel@chromium.org, Dec 10

Issue description

- remove the current html unittest
- closure compile the code and the unittest

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d0cc0dae3b1d105e82c72bfc5a979980af73320

commit 5d0cc0dae3b1d105e82c72bfc5a979980af73320
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 10 06:42:22 2018

Closure compile directory_model_unittest

 - remove directory_model_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - create the mocks in SetUp, rather than in each test case
 - add createElements() helper and use it in each test case
 - Fix Closure compile issues

No change in test behavior.

Bug:  913312 
Change-Id: I742cba92406711325281127e5dc4c2338030dbaa
Reviewed-on: https://chromium-review.googlesource.com/c/1369546
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615058}
[modify] https://crrev.com/5d0cc0dae3b1d105e82c72bfc5a979980af73320/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/5d0cc0dae3b1d105e82c72bfc5a979980af73320/ui/file_manager/file_manager/foreground/js/ui/BUILD.gn
[delete] https://crrev.com/4f4d94ebc24736cc86dcd3b2686e656791b4f4fc/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
[modify] https://crrev.com/5d0cc0dae3b1d105e82c72bfc5a979980af73320/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js

Owner: noel@chromium.org
Status: Fixed (was: Untriaged)

Sign in to add a comment