New issue
Advanced search Search tips

Issue 913311 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile content_metadata_provider_unittest

Project Member Reported by noel@chromium.org, Dec 10

Issue description

- remove the current html unittest
- closure compile the code and the unittest
 
Blocking: 860355
Labels: CrOSFilesCategory-Testing CrOSFilesCategory-CodeHealth
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a4b20804417e0cdbb4a442a521012f241c51647

commit 6a4b20804417e0cdbb4a442a521012f241c51647
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 10 04:49:10 2018

Closure compile content_metadata_provider_unittest

  - remove content_metadata_provider_unittest.html
  - add BUILD rules to auto-generate and compile the unittest
  - Fix Closure compile errors

Bug:  913311 
Change-Id: Ibc20b90bae87e9619d23882dc918dbf0653504a2
Reviewed-on: https://chromium-review.googlesource.com/c/1369544
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615046}
[modify] https://crrev.com/6a4b20804417e0cdbb4a442a521012f241c51647/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/6a4b20804417e0cdbb4a442a521012f241c51647/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[delete] https://crrev.com/4078dcc31aafc197f97ac909520ad524b46be4f0/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider_unittest.html
[modify] https://crrev.com/6a4b20804417e0cdbb4a442a521012f241c51647/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment