New issue
Advanced search Search tips

Issue 913307 link

Starred by 1 user
Status: Fixed
Owner:
noel@chromium.org
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile file_system_metadata_provider_unittest

Project Member Reported by noel@chromium.org, Dec 10 
- remove the current html unittest
- closure compile the code and the unittest

Comment 1 by noel@chromium.org, Dec 10

Summary: Closure compile file_system_metadata_provider_unittest (was: Closure compile file_system_metadata_provider _unittest)

Comment 2 by noel@chromium.org, Dec 10

Summary: Closure compile content_metadata_provider_unittest (was: Closure compile file_system_metadata_provider_unittest)

Comment 3 by noel@chromium.org, Dec 10

Summary: Closure compile file_system_metadata_provider_unittest (was: Closure compile content_metadata_provider_unittest)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df3ddf670536f2bfb7f100faa65d61a9dfe01730

commit df3ddf670536f2bfb7f100faa65d61a9dfe01730
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 10 07:29:19 2018

Closure compile file_system_metadata_provider_unittest

 - remove file_system_metadata_provider_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - fix Closure compiler errors

No change in test behavior.

Bug:  913307 
Change-Id: Ic8efcd922b9eab319e3369c9e334cd2e7365e9f4
Reviewed-on: https://chromium-review.googlesource.com/c/1369484
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615064}
[modify] https://crrev.com/df3ddf670536f2bfb7f100faa65d61a9dfe01730/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/df3ddf670536f2bfb7f100faa65d61a9dfe01730/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[delete] https://crrev.com/29a1d6e13e94f21833e478547bc2fe635491d139/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.html
[modify] https://crrev.com/df3ddf670536f2bfb7f100faa65d61a9dfe01730/ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.js

Comment 5 by noel@chromium.org, Dec 10

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50baf2ec7479eddaeb7d5e7913ee18bee2642291

commit 50baf2ec7479eddaeb7d5e7913ee18bee2642291
Author: Noel Gordon <noel@chromium.org>
Date: Thu Dec 13 05:11:16 2018

Only {MockFileSystem}s have a populate() method

Bug:  913307 
Change-Id: I3456ca59d276edde242a17f38f4868543b30ffcb
Reviewed-on: https://chromium-review.googlesource.com/c/1375190
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616217}
[modify] https://crrev.com/50baf2ec7479eddaeb7d5e7913ee18bee2642291/ui/file_manager/file_manager/foreground/js/import_controller_unittest.js
►

Sign in to add a comment