New issue
Advanced search Search tips

Issue 913302 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile metadata_cache_set_unittest

Project Member Reported by noel@chromium.org, Dec 10

Issue description

- remove the current html unittest
- closure compile the code and the unittest

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79f71470c8ee2b69a35fe8192eb01b8b3d5ca02b

commit 79f71470c8ee2b69a35fe8192eb01b8b3d5ca02b
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 10 06:00:44 2018

Closure compile metadata_cache_set_unittest

 - remove metadata_cache_set_unittest.html file
 - add BUILD rules to auto-generate and compile this unittest
 - fix Closure compiler errors

No change in test behavior.

Bug:  913302 
Change-Id: I4dd7227650ca686dc805079afea61963dc7a87cd
Reviewed-on: https://chromium-review.googlesource.com/c/1368862
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615052}
[modify] https://crrev.com/79f71470c8ee2b69a35fe8192eb01b8b3d5ca02b/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/79f71470c8ee2b69a35fe8192eb01b8b3d5ca02b/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[delete] https://crrev.com/29431f441911b54e653da4e4b51cdb2c9ffb9178/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.html
[modify] https://crrev.com/79f71470c8ee2b69a35fe8192eb01b8b3d5ca02b/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment