New issue
Advanced search Search tips

Issue 913300 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile metadata_model_unittest

Project Member Reported by noel@chromium.org, Dec 10

Issue description

- remove the current html unittest
- closure compile the code and the unittest

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f4d94ebc24736cc86dcd3b2686e656791b4f4fc

commit 4f4d94ebc24736cc86dcd3b2686e656791b4f4fc
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 10 06:39:24 2018

Closure compile metadata_model_unittest

 - remove multi_metadata_provider_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - fix Closure compiler errors

No change in test behavior.

Bug:  913300 
Change-Id: I1b8a33c635fd3622767a9860b4210f35c2d35e49
Reviewed-on: https://chromium-review.googlesource.com/c/1368857
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615057}
[modify] https://crrev.com/4f4d94ebc24736cc86dcd3b2686e656791b4f4fc/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/4f4d94ebc24736cc86dcd3b2686e656791b4f4fc/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[delete] https://crrev.com/25926832c991e99daffc84bac34b900c7fca924d/ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.html
[modify] https://crrev.com/4f4d94ebc24736cc86dcd3b2686e656791b4f4fc/ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment