Always prefer entity suggestions when deduping |
|||||||
Issue descriptionSee bug 886988 for background. After consultation with the Suggest team and some experimentation, we've decided to handle entity suggestions and equivalent (same query terms) non-entity suggestions in a new manner. The two should always be deduped and the entity suggestion should always be selected over the non-entity suggestion.
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/067b8ec9e9e3bf01b5baeea660b5ec4cb2f98f77 commit 067b8ec9e9e3bf01b5baeea660b5ec4cb2f98f77 Author: Justin Donnelly <jdonnelly@chromium.org> Date: Tue Dec 11 21:09:59 2018 [omnibox] Add unit tests for AutocompleteResult::IsBetterMatch. Also fix an issue with the score boosting. Bug: 913299 Change-Id: Ia44b6e8658a37a75a1f64776306d764dc73d25ae Reviewed-on: https://chromium-review.googlesource.com/c/1370394 Reviewed-by: Kevin Bailey <krb@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#615658} [modify] https://crrev.com/067b8ec9e9e3bf01b5baeea660b5ec4cb2f98f77/components/omnibox/browser/autocomplete_match.h [modify] https://crrev.com/067b8ec9e9e3bf01b5baeea660b5ec4cb2f98f77/components/omnibox/browser/autocomplete_result.cc [modify] https://crrev.com/067b8ec9e9e3bf01b5baeea660b5ec4cb2f98f77/components/omnibox/browser/autocomplete_result.h [modify] https://crrev.com/067b8ec9e9e3bf01b5baeea660b5ec4cb2f98f77/components/omnibox/browser/autocomplete_result_unittest.cc
,
Dec 12
Verified in latest Canary (73.0.3638.0 Mac). Request is to merge both CLs above. This is relatively low risk because the behavior affected is controlled by a flag (chrome://flags/#omnibox-rich-entity-suggestions).
,
Dec 12
Pls apply appropriate OSs label.
,
Dec 12
,
Dec 12
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b858e013a88132570f461686edf90e0c19ccbc0e commit b858e013a88132570f461686edf90e0c19ccbc0e Author: Justin Donnelly <jdonnelly@google.com> Date: Thu Dec 13 18:26:23 2018 [omnibox] Prefer entity suggestions when deduping. Changes the deduping logic in AutocompleteResult to choose entity suggestions over non-entity suggestions, even if they have a lower score. If they do have a lower score, promotes their score to that of the higher-scoring non-entity suggestion. Bug: 913299 Change-Id: I6197a216af0d4a6ca420acd34702ddbe14458c41 Reviewed-on: https://chromium-review.googlesource.com/c/1356016 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Kevin Bailey <krb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615032}(cherry picked from commit 5bb430afd60f1bbc54cad1039106913aad8dbede) Reviewed-on: https://chromium-review.googlesource.com/c/1376322 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#334} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/b858e013a88132570f461686edf90e0c19ccbc0e/components/omnibox/browser/autocomplete_result.cc [modify] https://crrev.com/b858e013a88132570f461686edf90e0c19ccbc0e/components/omnibox/browser/autocomplete_result.h
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b1678f4ed34a87561e23152c778556643f3e73d commit 9b1678f4ed34a87561e23152c778556643f3e73d Author: Justin Donnelly <jdonnelly@chromium.org> Date: Thu Dec 13 18:27:41 2018 [omnibox] Add unit tests for AutocompleteResult::IsBetterMatch. Also fix an issue with the score boosting. Bug: 913299 Change-Id: Ia44b6e8658a37a75a1f64776306d764dc73d25ae Reviewed-on: https://chromium-review.googlesource.com/c/1370394 Reviewed-by: Kevin Bailey <krb@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615658}(cherry picked from commit 067b8ec9e9e3bf01b5baeea660b5ec4cb2f98f77) Reviewed-on: https://chromium-review.googlesource.com/c/1376212 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#335} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/9b1678f4ed34a87561e23152c778556643f3e73d/components/omnibox/browser/autocomplete_match.h [modify] https://crrev.com/9b1678f4ed34a87561e23152c778556643f3e73d/components/omnibox/browser/autocomplete_result.cc [modify] https://crrev.com/9b1678f4ed34a87561e23152c778556643f3e73d/components/omnibox/browser/autocomplete_result.h [modify] https://crrev.com/9b1678f4ed34a87561e23152c778556643f3e73d/components/omnibox/browser/autocomplete_result_unittest.cc
,
Dec 13
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b1678f4ed34a87561e23152c778556643f3e73d Commit: 9b1678f4ed34a87561e23152c778556643f3e73d Author: jdonnelly@chromium.org Commiter: jdonnelly@chromium.org Date: 2018-12-13 18:27:41 +0000 UTC [omnibox] Add unit tests for AutocompleteResult::IsBetterMatch. Also fix an issue with the score boosting. Bug: 913299 Change-Id: Ia44b6e8658a37a75a1f64776306d764dc73d25ae Reviewed-on: https://chromium-review.googlesource.com/c/1370394 Reviewed-by: Kevin Bailey <krb@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615658}(cherry picked from commit 067b8ec9e9e3bf01b5baeea660b5ec4cb2f98f77) Reviewed-on: https://chromium-review.googlesource.com/c/1376212 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#335} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b858e013a88132570f461686edf90e0c19ccbc0e Commit: b858e013a88132570f461686edf90e0c19ccbc0e Author: jdonnelly@google.com Commiter: jdonnelly@chromium.org Date: 2018-12-13 18:26:23 +0000 UTC [omnibox] Prefer entity suggestions when deduping. Changes the deduping logic in AutocompleteResult to choose entity suggestions over non-entity suggestions, even if they have a lower score. If they do have a lower score, promotes their score to that of the higher-scoring non-entity suggestion. Bug: 913299 Change-Id: I6197a216af0d4a6ca420acd34702ddbe14458c41 Reviewed-on: https://chromium-review.googlesource.com/c/1356016 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Kevin Bailey <krb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#615032}(cherry picked from commit 5bb430afd60f1bbc54cad1039106913aad8dbede) Reviewed-on: https://chromium-review.googlesource.com/c/1376322 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#334} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Dec 10