New issue
Advanced search Search tips

Issue 913294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 860355



Sign in to add a comment

Closure compile multi_metadata_provider_unittest

Project Member Reported by noel@chromium.org, Dec 10

Issue description

- remove the current html unittest
- closure compile the code and the unittest
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c86d3822692fdb802047c283009c82f7e35cecc5

commit c86d3822692fdb802047c283009c82f7e35cecc5
Author: Noel Gordon <noel@chromium.org>
Date: Mon Dec 10 02:02:23 2018

Closure compile multi_metadata_provider_unittest

 - remove multi_metadata_provider_unittest.html
 - add BUILD rules to auto-generate and compile this unittest
 - fix Closure compiler errors.

No change in test behavior.

Bug:  913294 
Change-Id: I97f20c329f6ba89e0f4580be8d1e52f68331fe25
Reviewed-on: https://chromium-review.googlesource.com/c/1368856
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615029}
[modify] https://crrev.com/c86d3822692fdb802047c283009c82f7e35cecc5/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/c86d3822692fdb802047c283009c82f7e35cecc5/ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
[delete] https://crrev.com/6b4d81b2d610bba6e691389b2ef771db17c40498/ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.html
[modify] https://crrev.com/c86d3822692fdb802047c283009c82f7e35cecc5/ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.js

Status: Fixed (was: Started)

Sign in to add a comment