Closure compile files_tooltip_unittest |
||
Issue description- add the directory to ui/file_manager BUILD.gn unittest rules - remove the current html unittest - closure compile the code and the unittest
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5258d4567703372638ceaa5f84471c147b503f6f commit 5258d4567703372638ceaa5f84471c147b503f6f Author: Noel Gordon <noel@chromium.org> Date: Mon Dec 10 07:01:34 2018 Closure compile files_tooltip_unittest - remove files_tooltip_unittest.html - add BUILD rules to auto-generate and compile this unittest - dynamically construct the test page in-situ - make the test harness pause until the test page is fully loaded - fix Closure compile errors Bug: 913287 Change-Id: I3e6594b7a28aec299905be87250136b21f82c330 Reviewed-on: https://chromium-review.googlesource.com/c/1368855 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615062} [modify] https://crrev.com/5258d4567703372638ceaa5f84471c147b503f6f/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/5258d4567703372638ceaa5f84471c147b503f6f/ui/file_manager/BUILD.gn [modify] https://crrev.com/5258d4567703372638ceaa5f84471c147b503f6f/ui/file_manager/file_manager/foreground/elements/BUILD.gn [modify] https://crrev.com/5258d4567703372638ceaa5f84471c147b503f6f/ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.html [modify] https://crrev.com/5258d4567703372638ceaa5f84471c147b503f6f/ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.js
,
Dec 10
|
||
►
Sign in to add a comment |
||
Comment 1 by noel@chromium.org
, Dec 10Labels: -cors CrOSFilesCategory-Testing CrOSFilesCategory-CodeHealth OS-Chrome