crash_sender does not ignore device core files |
||||||||
Issue descriptionThis was regressed in https://chromium-review.googlesource.com/1290411 but wasn't caught since referencing undefined variables is not an error in shell script (unless "set -u" is used).
,
Dec 10
,
Dec 11
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d6d06df3c622ec163d95b2bd404b884a0f8d323f commit d6d06df3c622ec163d95b2bd404b884a0f8d323f Author: Satoru Takabayashi <satorux@google.com> Date: Tue Dec 11 23:56:30 2018 crash: Fix a bug where devcore file isn't ignored correctly This was regressed in https://chromium-review.googlesource.com/1290411 but wasn't caught since referencing undefined variables is not an error in shell script (unless "set -u" is used). BUG=chromium:391887, chromium:913285 TEST=manually create a devcore meta file, and ensure that it's ignored Change-Id: Ie8b4adbc8f4cd91dd2d9c2dea6084fe66ed96f66 Reviewed-on: https://chromium-review.googlesource.com/1369364 Commit-Ready: Satoru Takabayashi <satorux@google.com> Tested-by: Satoru Takabayashi <satorux@google.com> Reviewed-by: Mike Frysinger <vapier@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/1372868 Trybot-Ready: Satoru Takabayashi <satorux@google.com> Commit-Queue: Satoru Takabayashi <satorux@google.com> [modify] https://crrev.com/d6d06df3c622ec163d95b2bd404b884a0f8d323f/crash-reporter/crash_sender.sh
,
Dec 12
,
Dec 17
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 17
merge was done in #4
,
Dec 17
,
Dec 18
oops. thanks vapier for adding the right label! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 10