New issue
Advanced search Search tips

Issue 913285 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 12
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

crash_sender does not ignore device core files

Project Member Reported by satorux@chromium.org, Dec 10

Issue description

This was regressed in https://chromium-review.googlesource.com/1290411
but wasn't caught since referencing undefined variables is not an error
in shell script (unless "set -u" is used).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/375f6ee96d333d03fcd96e22db3ffdb93f8290d1

commit 375f6ee96d333d03fcd96e22db3ffdb93f8290d1
Author: Satoru Takabayashi <satorux@google.com>
Date: Mon Dec 10 16:42:37 2018

crash: Fix a bug where devcore file isn't ignored correctly

This was regressed in https://chromium-review.googlesource.com/1290411
but wasn't caught since referencing undefined variables is not an error
in shell script (unless "set -u" is used).

BUG=chromium:391887, chromium:913285 
TEST=manually create a devcore meta file, and ensure that it's ignored

Change-Id: Ie8b4adbc8f4cd91dd2d9c2dea6084fe66ed96f66
Reviewed-on: https://chromium-review.googlesource.com/1369364
Commit-Ready: Satoru Takabayashi <satorux@google.com>
Tested-by: Satoru Takabayashi <satorux@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/375f6ee96d333d03fcd96e22db3ffdb93f8290d1/crash-reporter/crash_sender.sh

Labels: M-72 Merge-Request-72
Labels: -Merge-Request-72 Merge-Approved-72
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11

Labels: merge-merged-release-R72-11316.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d6d06df3c622ec163d95b2bd404b884a0f8d323f

commit d6d06df3c622ec163d95b2bd404b884a0f8d323f
Author: Satoru Takabayashi <satorux@google.com>
Date: Tue Dec 11 23:56:30 2018

crash: Fix a bug where devcore file isn't ignored correctly

This was regressed in https://chromium-review.googlesource.com/1290411
but wasn't caught since referencing undefined variables is not an error
in shell script (unless "set -u" is used).

BUG=chromium:391887, chromium:913285 
TEST=manually create a devcore meta file, and ensure that it's ignored

Change-Id: Ie8b4adbc8f4cd91dd2d9c2dea6084fe66ed96f66
Reviewed-on: https://chromium-review.googlesource.com/1369364
Commit-Ready: Satoru Takabayashi <satorux@google.com>
Tested-by: Satoru Takabayashi <satorux@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/1372868
Trybot-Ready: Satoru Takabayashi <satorux@google.com>
Commit-Queue: Satoru Takabayashi <satorux@google.com>

[modify] https://crrev.com/d6d06df3c622ec163d95b2bd404b884a0f8d323f/crash-reporter/crash_sender.sh

Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 17

Cc: djmm@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-72
merge was done in #4
Labels: Merge-Merged
oops. thanks vapier for adding the right label!

Sign in to add a comment