New issue
Advanced search Search tips

Issue 913278 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
Launcher-Broken


Sign in to add a comment

List of Chrome windows missing when it doesn't fit on the screen

Reported by wpwoo...@gmail.com, Dec 9

Issue description

UserAgent: Mozilla/5.0 (X11; CrOS x86_64 11151.51.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.85 Safari/537.36
Platform: 11151.51.0 (Official Build) beta-channel eve

Steps to reproduce the problem:
1. Open some windows in Chrome
2. Click the Chrome icon on the shelf (shelf on bottom)

What is the expected behavior?
A list of Chrome windows is shown (or a list of Chrome tabs if "Shift" is pressed while clicking the Chrome icon).

What went wrong?
The Chrome icon highlights but no windows (tabs) are shown.

Did this work before? Yes First CrOS 71 beta

Chrome version: 71.0.3578.85  Channel: beta
OS Version: 11151.51.0
Flash Version: 32.0.0.101 

In the first attached photo you can see the mouse over the Chrome icon, which I have just clicked.  No Window list appears.  I have about 20 Chrome windows open.

In the second image, you can see what happens when the shelf is on the right.  The window list is partially shown but the top of the list is cut off and there is no way to see it.  This is also a regression, as it used to show a list of windows from top of screen to bottom, with scroll arrows at the top and bottom of the list.
 

Sorry, attachments are here.  In the first attached photo you can see the mouse over the Chrome icon, which I have just clicked.  No Window list appears.  I have about 20 Chrome windows open.

In the second image, you can see what happens when the shelf is on the right.  The window list is partially shown but the top of the list is cut off and there is no way to see it.  This is also a regression, as it used to show a list of windows from top of screen to bottom, with scroll arrows at the top and bottom of the list.
IMG_20181209_170929 (1) (1).jpg
3.8 MB View Download
IMG_20181209_171520 (1) (1).jpg
3.6 MB View Download

Comment 2 Deleted

I did some testing and when the shelf is on the bottom, this starts happening when there are more than 20 Chrome windows.  20 or less, and the window list is shown.

In previous versions of Chrome OS, scroll arrows were shown when there were too many windows to show all of them on the screen.
Components: -UI UI>Shell>Shelf
Labels: M-73
Summary: List of Chrome windows missing when more than 20 windows (was: Window list not shown when clicking on Chrome icon in shelf)
I cannot reproduce this. In the attached screenshot, I count 25 windows, the window list appears as expected.
2018-12-26-153053_1438x1278_scrot.png
618 KB View Download
Summary: List of Chrome windows missing when it doesn't fit on the screen (was: List of Chrome windows missing when more than 20 windows)
Ah, now I can see this too. The screen viewport needs to be too small to accommodate the menu.
2018-12-26-153332_718x852_scrot.png
217 KB View Download
Owner: manucornet@chromium.org
Status: Assigned (was: Unconfirmed)
It's also worth noting that with a shelf on the left or right, the menu does open but it's not very optimally placed.
2018-12-29-004821_718x638_scrot.png
146 KB View Download
Owner: newcomer@chromium.org
@Alex you probably have a lot more context than I do about menu layout code (I see you made some changes in June but that sounds too early for it to cause this regression assuming it regressed in 71). Any idea what could cause this? This isn't handled in shelf code per se...
Labels: -Pri-2 Pri-1
This should all be in the shared menu component.

I'll do a bisect and figure out what's going on. If it's a simple fix, I'll merge to M-72. Unfortunately we can't fix this in M-71.

Comment 14 by newcomer@chromium.org, Jan 18 (4 days ago)

Something is wrong with MenuController::CalculateBubbleMenuBounds.

If I use MenuController::CalculateMenuBounds instead, the menu shows up.

Comment 15 by newcomer@google.com, Today (6 hours ago)

This is a pretty quick fix, so I will try to merge it to M-72. Sorry that this broke your workflow!

https://chromium-review.googlesource.com/c/chromium/src/+/1428603

Sign in to add a comment