New issue
Advanced search Search tips

Issue 913274 link

Starred by 3 users
Status: Fixed
Owner:
dfried@chromium.org
Closed: Dec 11
Cc:
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Dragging hidden extension icons in the Settings menu ends with a broken alignment

Project Member Reported by meh...@chromium.org, Dec 9 
Chrome Version: Canary 73.0.3635.0
OS: macOS 10.14.2

What steps will reproduce the problem?
(1) Install some extensions
(2) Resize the Omnibox, so that the extension icon are hidden in the Settings menu
(3) Click on the Settings icon, so that the Menu appears
(4) Drag one of the extension icons to another position

What is the expected result?
No alignment issue in the menu.

What happens instead?
The position of icons are unaligned.

A screencast is attached.

This is a regression in ChromeCanary. Works fine in Chrome Stable.
screencast.mov
1.3 MB View Download

Comment 1 by meh...@chromium.org, Dec 9

Owner: dfried@chromium.org
Status: Assigned (was: Untriaged)
Regression range: https://chromium.googlesource.com/chromium/src/+log/d51ff5d6f3d174327fed6e4598e32cba7c6122f4..3b02ba2fcf5de04a3dbaa51b3e7c43df5a376924

dfried@: Can you please check, if this can be caused by your CL https://chromium-review.googlesource.com/c/chromium/src/+/1368274 ?

Thanks in advance.

Comment 2 by meh...@chromium.org, Dec 9

Labels: M-73

Comment 3 by ajha@chromium.org, Dec 10

Labels: -Needs-Bisect ReleaseBlock-Stable RegressedIn-73 Target-73 FoundIn-73 hasbisect

Comment 4 by dfried@chromium.org, Dec 11 

It's possible it is a regression due to the CL, though not to the main part of it. I'll track it down; let's not revert it preemptively (we have time to fix this).

Comment 5 by dfried@chromium.org, Dec 11

Status: Started (was: Assigned)
I have determined this CL caused the regression, and am now figuring out why.

Comment 6 Deleted

Comment 7 by dfried@chromium.org, Dec 11 

Fix forthcoming.
Unfortunately, there is a problem with the underlying code which my change uncovered. My fix is just a band-aid to prevent the regression; you can read more about the underlying problem at issue #913998
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5067f2ca9220fc06511f1ab299bcf50a8262d3b4

commit 5067f2ca9220fc06511f1ab299bcf50a8262d3b4
Author: Dana Fried <dfried@chromium.org>
Date: Tue Dec 11 21:16:18 2018

Fix layout issue with overflow extensions view.

Bug:  913274 
Change-Id: I8ca09d553d4cce55887604f07300aa0685a7f498
Reviewed-on: https://chromium-review.googlesource.com/c/1372309
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615662}
[modify] https://crrev.com/5067f2ca9220fc06511f1ab299bcf50a8262d3b4/ui/views/controls/menu/menu_item_view.cc

Comment 9 by dfried@chromium.org, Dec 11

Status: Fixed (was: Started)

Comment 10 by meh...@chromium.org, Dec 11 

Thanks :)

Comment 11 by susan.boorgula@chromium.org, Dec 12

Labels: TE-Verified-73.0.3638.0 TE-Verified-M73
Able to reproduce this issue on Mac OS 10.13.6 on the reported version 73.0.3635.0 and the issue is fixed on the latest M-73 build 73.0.3638.0.

1. launched Chrome and install few extensions.
2. Resized the Omnibox and the extension icons are hidden in the Settings menu
3. Click on the Settings icon and drag one of the extension icons to another position.
4. Could observe that the extension icons are aligned.
Attached is the screen cast for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
913274.mp4
338 KB View Download
►

Sign in to add a comment