New issue
Advanced search Search tips

Issue 913225 link

Starred by 1 user
Status: Fixed
Owner:
jiahuiguo@chromium.org
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Merge Request M72] Add credit card icon animation when migration is in process

Project Member Reported by jiahuiguo@chromium.org, Dec 8 
Request to merge CL https://chromium-review.googlesource.com/c/chromium/src/+/1361871.

verified in Canary 73.0.3634.2. See attached demo.

The feature is controlled by project's Finch flag. No other project/feature touches this file.

Thanks!
Demo.mov
6.5 MB View Download
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 9

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by jsaul@google.com, Dec 10

Status: Fixed (was: Untriaged)
Merged as https://chromium-review.googlesource.com/c/chromium/src/+/1371025, marking as Fixed.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 10

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e5801b1cfbc4e99255e87e442d1db199e1843d4

commit 5e5801b1cfbc4e99255e87e442d1db199e1843d4
Author: siyua <siyua@chromium.org>
Date: Mon Dec 10 22:40:11 2018

[AF Paradise] Add credit card icon animation when migration is in process

Bug:  913225 
Change-Id: Id178c933ba55dec0979270469df409581ab9052b
Reviewed-on: https://chromium-review.googlesource.com/c/1361871
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614885}(cherry picked from commit 995946d8c8e3f9d95975f74d05a4517c925fecdb)
Reviewed-on: https://chromium-review.googlesource.com/c/1371025
Cr-Commit-Position: refs/branch-heads/3626@{#239}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/5e5801b1cfbc4e99255e87e442d1db199e1843d4/chrome/browser/ui/views/autofill/local_card_migration_icon_view.cc
[modify] https://crrev.com/5e5801b1cfbc4e99255e87e442d1db199e1843d4/chrome/browser/ui/views/autofill/local_card_migration_icon_view.h
[modify] https://crrev.com/5e5801b1cfbc4e99255e87e442d1db199e1843d4/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/5e5801b1cfbc4e99255e87e442d1db199e1843d4/components/autofill_strings.grdp
[add] https://crrev.com/5e5801b1cfbc4e99255e87e442d1db199e1843d4/components/autofill_strings_grdp/IDS_AUTOFILL_LOCAL_CARD_MIGRATION_ANIMATION_LABEL.png.sha1
Project Member

Comment 4 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/5e5801b1cfbc4e99255e87e442d1db199e1843d4

Commit: 5e5801b1cfbc4e99255e87e442d1db199e1843d4
Author: siyua@chromium.org
Commiter: jsaul@google.com
Date: 2018-12-10 22:40:11 +0000 UTC

[AF Paradise] Add credit card icon animation when migration is in process

Bug:  913225 
Change-Id: Id178c933ba55dec0979270469df409581ab9052b
Reviewed-on: https://chromium-review.googlesource.com/c/1361871
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614885}(cherry picked from commit 995946d8c8e3f9d95975f74d05a4517c925fecdb)
Reviewed-on: https://chromium-review.googlesource.com/c/1371025
Cr-Commit-Position: refs/branch-heads/3626@{#239}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment