[Merge Request M72] Change the timing of showing credit card icon in the omnibox |
||||
Issue descriptionRequest merge the following CL to M72, https://chromium-review.googlesource.com/c/chromium/src/+/1356260 Previously when migration dialog was shown, the credit card icon was not visible. In this change, we change it to: Credit card icon will always be visible when migration dialog is shown, verified in Canary 73.0.3634.2. See attached demo. The feature is controlled by project's Finch flag. No other project/feature touches this file. Thanks!
,
Dec 10
Merged as https://chromium-review.googlesource.com/c/chromium/src/+/1371004; marking as Fixed.
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c600e5e7f68e792b3138abe25f162531e7cc53d6 commit c600e5e7f68e792b3138abe25f162531e7cc53d6 Author: Jared Saul <jsaul@google.com> Date: Mon Dec 10 22:37:59 2018 [AF Paradise] Change the timing of showing credit card icon in the omnibox Previously when migration dialog was shown, the credit card icon was not visible. In this change, we change it to: Credit card icon will always be visible when migration dialog is shown. 1) Add more step in LocalCardMigrationFlowStep. The MIGRATION_RESULT_PENDING will be used for the animation in the next CL. 2) Use the observer pattern for dialog controller to pass correct state to manage_migration_ui_controller when user clicks okay/cancel button. 3) Change the new link navigation to pop-ups since the dialog is blocking the browser now. Using TBR because this merge had a conflict and needed to fix manually: TBR=estade@chromium.org (cherry picked from commit 1519a34eff922497f280e53a035e019e8f10b436) Bug: 913224 Change-Id: I32acf9136d1d0298f23cc79ede99f223a01566c1 Reviewed-on: https://chromium-review.googlesource.com/c/1356260 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614554} Reviewed-on: https://chromium-review.googlesource.com/c/1371004 Cr-Commit-Position: refs/branch-heads/3626@{#238} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/chrome/browser/ui/autofill/local_card_migration_controller_observer.h [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.cc [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.h [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/chrome/browser/ui/autofill/manage_migration_ui_controller.cc [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/chrome/browser/ui/autofill/manage_migration_ui_controller.h [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/chrome/browser/ui/views/autofill/local_card_migration_error_dialog_view.cc [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/chrome/browser/ui/views/autofill/local_card_migration_error_dialog_view.h [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/chrome/browser/ui/views/autofill/local_card_migration_icon_view.cc [modify] https://crrev.com/c600e5e7f68e792b3138abe25f162531e7cc53d6/components/autofill/core/browser/ui/local_card_migration_dialog_controller.h
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c600e5e7f68e792b3138abe25f162531e7cc53d6 Commit: c600e5e7f68e792b3138abe25f162531e7cc53d6 Author: jsaul@google.com Commiter: jsaul@google.com Date: 2018-12-10 22:37:59 +0000 UTC [AF Paradise] Change the timing of showing credit card icon in the omnibox Previously when migration dialog was shown, the credit card icon was not visible. In this change, we change it to: Credit card icon will always be visible when migration dialog is shown. 1) Add more step in LocalCardMigrationFlowStep. The MIGRATION_RESULT_PENDING will be used for the animation in the next CL. 2) Use the observer pattern for dialog controller to pass correct state to manage_migration_ui_controller when user clicks okay/cancel button. 3) Change the new link navigation to pop-ups since the dialog is blocking the browser now. Using TBR because this merge had a conflict and needed to fix manually: TBR=estade@chromium.org (cherry picked from commit 1519a34eff922497f280e53a035e019e8f10b436) Bug: 913224 Change-Id: I32acf9136d1d0298f23cc79ede99f223a01566c1 Reviewed-on: https://chromium-review.googlesource.com/c/1356260 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614554} Reviewed-on: https://chromium-review.googlesource.com/c/1371004 Cr-Commit-Position: refs/branch-heads/3626@{#238} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||
►
Sign in to add a comment |
||||
Comment 1 by sheriffbot@chromium.org
, Dec 9