New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 913204 link

Starred by 1 user
Status: Duplicate
Merged: issue 908474
Owner:
█ uwyiming@chromium.org
Last visit > 30 days ago
Closed: Dec 21
Cc:
szager@chromium.org
yhirano@chromium.org
█ uwyiming@chromium.org
█ ramyan@chromium.org
mamir@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

captured_sites_interactive_tests is not deterministic.

Project Member Reported by hua...@chromium.org, Dec 8 
Builder "Deterministic Linux (dbg)" is failing in compare_build_artifacts, e.g.:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux%20%28dbg%29/3717
  => compare_build_artifacts -> stdout:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8927734472396566352/+/steps/compare_build_artifacts/0/stdout

Searching for "(unexpected)", we see the failing entry is

  captured_sites_interactive_tests

Looks like this was added recently in

  https://chromium-review.googlesource.com/c/1364081

And this happened when the Deterministic bots were undergoing "Failure generate .isolate files" failures (see  bug 913171 ). Perhaps some mechanism to filter (via presubmit) or auto-white-list captured_sites_interactive_tests didn't run?

Anyway we can probably just white-list the test.

Comment 1 by hua...@chromium.org, Dec 8

Labels: -Pri-3 Pri-2
Owner: uwyiming@chromium.org
Status: Assigned (was: Untriaged)
Summary: captured_sites_interactive_tests is not deterministic. (was: Deterministic bots failing on compare_build_artifacts from captured_sites_interactive_tests failure. )
From
  /tools/determinism/deterministic_build_whitelist.pyl

The goal is to make everything deterministic. So I'm changing the title.

I'm going to add the test to the white list to de-noise the bots, but this does not solve the underlying issue, which I'm going to assign to uwyiming@ to triage.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bf35122bd88796351a4ae449154a12841c246e2

commit 0bf35122bd88796351a4ae449154a12841c246e2
Author: Samuel Huang <huangs@chromium.org>
Date: Sat Dec 08 18:29:09 2018

[Sheriffing] Add captured_sites_interactive_tests to Deterministic Linux whitelist.

Bug:  913204 
Tbr: dpranke@chromium.org
Change-Id: I35d988b817328c444762eee2bccc62135e67fc53
Reviewed-on: https://chromium-review.googlesource.com/c/1369213
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614977}
[modify] https://crrev.com/0bf35122bd88796351a4ae449154a12841c246e2/tools/determinism/deterministic_build_whitelist.pyl

Comment 3 by thakis@chromium.org, Dec 21

Mergedinto: 908474
Status: Duplicate (was: Assigned)
This looks like the "targets with .S files aren't deterministic" bug.
►

Sign in to add a comment