CrFocusRowBehaviorTest.FocusTest is flaky |
|||||
Issue descriptionFindit identified the culprit r614606 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOWQ4OTA0ODZkZWVmNGY0ODIyMzQ0ZmE3MzRjYWZjYzJiZTc3ODgwNQw Please revert the culprit, or disable the test(s) and find the appropriate owner to fix or delete. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r614606&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOWQ4OTA0ODZkZWVmNGY0ODIyMzQ0ZmE3MzRjYWZjYzJiZTc3ODgwNQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Dec 10
,
Dec 11
,
Dec 12
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5fbc5b2cf493013690c40ec5c27b539033c959eb commit 5fbc5b2cf493013690c40ec5c27b539033c959eb Author: rbpotter <rbpotter@chromium.org> Date: Wed Dec 12 02:46:09 2018 CrFocusRowBehavior: Fix flaky test Locally reproduced the test failure and determined that async setup in FocusRowBehavior was often not actually completed before tests were started. Waiting for one more render to ensure async setup is complete prevents the flakes. Bug: 913197 Change-Id: Ifb893927ecf83666f5edb201c81cb5ce49791fc0 Reviewed-on: https://chromium-review.googlesource.com/c/1372831 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#615797} [modify] https://crrev.com/5fbc5b2cf493013690c40ec5c27b539033c959eb/chrome/test/data/webui/cr_focus_row_behavior_test.js
,
Dec 13
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by yhirano@chromium.org
, Dec 10