Bookmark import joins multiple same named bookmark folders into a single folder
Reported by
youtube....@sbeh.de,
Dec 8
|
||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36 Steps to reproduce the problem: 1. Start chromium with a clean profile 2. Create 2 bookmark folders with the same name 3. Export, delete and re-import bookmarks OR 1. Watch this: https://www.youtube.com/watch?v=FjD3I4BHEec&feature=youtu.be What is the expected behavior? I expect the bookmark import to create multiple same named bookmark folders instead of re-usage. What went wrong? The exported .html-file has the multiple folders stored in it, the import just re-uses already existing folders. Did this work before? No Chrome version: 67.0.3396.99 Channel: stable OS Version: 10.0 Flash Version:
,
Jan 10
Able to reproduce the issue on reported chrome version #67.0.3396.99,latest stable # 71.0.3578.98 and latest chrome #73.0.3666.0 using Mac OS 10.13.6 , Ubuntu 17.10 and Windows 10 by following steps as per comment#0. The behavior is seen from M-60. This is non regression issue hence marking it as untraiged and requesting some one from dev team to look into the issue. Thanks
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daa895c08c58ef0cbef232ec0cf9efac4cf5b12e commit daa895c08c58ef0cbef232ec0cf9efac4cf5b12e Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Jan 11 11:11:20 2019 Add task_runner params to some of mojo bindings and use it. Support |task_runner| parameter in: - mojo::BindingSet::AddBinding - mojo::StrongBinding - mojo::StrongAssociatedBinding Using per-frame task runner at mojo is necessary for bfcache since JavaScript execution needs to be suspended when the tab is frozen. This CL is based on Alexander's CL: https://chromium-review.googlesource.com/c/chromium/src/+/1369499 Bug: 913192 Change-Id: I3a2a7193f22313ec39383a7794f08ddff3bf8375 Reviewed-on: https://chromium-review.googlesource.com/c/1379608 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#621969} [modify] https://crrev.com/daa895c08c58ef0cbef232ec0cf9efac4cf5b12e/content/browser/dom_storage/session_storage_area_impl_unittest.cc [modify] https://crrev.com/daa895c08c58ef0cbef232ec0cf9efac4cf5b12e/mojo/public/cpp/bindings/binding_set.h [modify] https://crrev.com/daa895c08c58ef0cbef232ec0cf9efac4cf5b12e/mojo/public/cpp/bindings/strong_associated_binding.h [modify] https://crrev.com/daa895c08c58ef0cbef232ec0cf9efac4cf5b12e/mojo/public/cpp/bindings/strong_binding.h [modify] https://crrev.com/daa895c08c58ef0cbef232ec0cf9efac4cf5b12e/third_party/blink/renderer/modules/app_banner/app_banner_controller.cc [modify] https://crrev.com/daa895c08c58ef0cbef232ec0cf9efac4cf5b12e/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_characteristic.cc [modify] https://crrev.com/daa895c08c58ef0cbef232ec0cf9efac4cf5b12e/third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_server.cc |
||
►
Sign in to add a comment |
||
Comment 1 by susan.boorgula@chromium.org
, Dec 9