org.chromium.chrome.browser.autofill.keyboard_accessory.ManualFillingUiCaptureTest#testCaptureKeyboardAccessoryWithPasswords is flaky. Findit has detected 3 flake occurrences of this test within the past 24 hours. List of all flake occurrences can be found at: https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyqAELEgVGbGFrZSKcAWNocm9taXVtQGNocm9tZV9wdWJsaWNfdGVzdF9hcGtAb3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLmF1dG9maWxsLmtleWJvYXJkX2FjY2Vzc29yeS5NYW51YWxGaWxsaW5nVWlDYXB0dXJlVGVzdCN0ZXN0Q2FwdHVyZUtleWJvYXJkQWNjZXNzb3J5V2l0aFBhc3N3b3Jkcww. Unless the culprit CL is found and reverted, please disable this test first within 30 minutes then find an appropriate owner. If the result above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Detection%20-%20Wrong%20result%20for%20org.chromium.chrome.browser.autofill.keyboard_accessory.ManualFillingUiCaptureTest#testCaptureKeyboardAccessoryWithPasswords&comment=Link%20to%20flake%20occurrences%3A%20https://findit-for-me.appspot.com/flake/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyqAELEgVGbGFrZSKcAWNocm9taXVtQGNocm9tZV9wdWJsaWNfdGVzdF9hcGtAb3JnLmNocm9taXVtLmNocm9tZS5icm93c2VyLmF1dG9maWxsLmtleWJvYXJkX2FjY2Vzc29yeS5NYW51YWxGaWxsaW5nVWlDYXB0dXJlVGVzdCN0ZXN0Q2FwdHVyZUtleWJvYXJkQWNjZXNzb3J5V2l0aFBhc3N3b3Jkcww Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
I have written a patch to disable the test https://chromium-review.googlesource.com/c/chromium/src/+/1369928
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d20372bed4393fc15612798427847dd7c9a7d1b0 commit d20372bed4393fc15612798427847dd7c9a7d1b0 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Mon Dec 10 10:42:39 2018 Disable flaky testCaptureKeyboardAccessoryWithPasswords TBR=fhorschig@chromium.org Bug: 913178 Change-Id: Ic68359d0f21afcda98ba853b908420078cacd9f0 Reviewed-on: https://chromium-review.googlesource.com/c/1369928 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#615077} [modify] https://crrev.com/d20372bed4393fc15612798427847dd7c9a7d1b0/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingUiCaptureTest.java
Test is disabled and owner if aware of it. Removing from Sheriff queue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/937f6250959d6b976b2a52a3d8b5360af1c80957 commit 937f6250959d6b976b2a52a3d8b5360af1c80957 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Thu Jan 10 08:55:59 2019 [Android] Deflake ManualFillingUiCaptureTests The tests fail while waiting for the home button (which I mistakenly used as a more stable signal that the UI is done loading). Apparently, the home button depends on AppSharedPreferences which are not guaranteed to enable it. Removing that and increasing the waiting time instead. Bug: 911177, 913178 , 908174 Change-Id: I3da5a586dbeeb8bad21523a77e02ce8c46d9467e Reviewed-on: https://chromium-review.googlesource.com/c/1403455 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#621510} [modify] https://crrev.com/937f6250959d6b976b2a52a3d8b5360af1c80957/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingTestHelper.java [modify] https://crrev.com/937f6250959d6b976b2a52a3d8b5360af1c80957/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingUiCaptureTest.java
Comment 1 by mamir@chromium.org
, Dec 10