New issue
Advanced search Search tips

Issue 913175 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 889261



Sign in to add a comment

Crostini Files flag removed

Project Member Reported by joelhockey@chromium.org, Dec 8

Issue description

Crostini Files flag is no longer shown at chrome://flags

It was inadvertently reomoved in https://chromium-review.googlesource.com/c/chromium/src/+/1362010
 
Blocking: 889261
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39d4a75a1ef2eb572a779f36c6f1f0a11be86d75

commit 39d4a75a1ef2eb572a779f36c6f1f0a11be86d75
Author: Joel Hockey <joelhockey@chromium.org>
Date: Sun Dec 09 21:36:42 2018

FilesApp crostini: make crostini-files flag visible to users

The flag was inadvertently removed when making the feature
disabled by default for M72 in crosreview.com/1362010

Flag changed from 'disable-crostini-files' to 'crostini-files'

Bug:  913175 
Bug: 889261
Change-Id: If5a8a79de941612a9f8a274b2702a032d4f1fa25
Reviewed-on: https://chromium-review.googlesource.com/c/1368847
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615010}
[modify] https://crrev.com/39d4a75a1ef2eb572a779f36c6f1f0a11be86d75/chrome/browser/about_flags.cc
[modify] https://crrev.com/39d4a75a1ef2eb572a779f36c6f1f0a11be86d75/chrome/browser/flag-metadata.json

Labels: Merge-Request-72
Labels: -Merge-Request-72 Merge-Approved-72
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 10

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55d4c7aa6b0e5bb284e48526d410a489b7ed36e1

commit 55d4c7aa6b0e5bb284e48526d410a489b7ed36e1
Author: Joel Hockey <joelhockey@chromium.org>
Date: Mon Dec 10 08:27:33 2018

FilesApp crostini: make crostini-files flag visible to users

The flag was inadvertently removed when making the feature
disabled by default for M72 in crosreview.com/1362010

Flag changed from 'disable-crostini-files' to 'crostini-files'

Bug:  913175 
Bug: 889261
Change-Id: If5a8a79de941612a9f8a274b2702a032d4f1fa25
Reviewed-on: https://chromium-review.googlesource.com/c/1368847
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615010}(cherry picked from commit 39d4a75a1ef2eb572a779f36c6f1f0a11be86d75)
Reviewed-on: https://chromium-review.googlesource.com/c/1368851
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#174}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/55d4c7aa6b0e5bb284e48526d410a489b7ed36e1/chrome/browser/about_flags.cc
[modify] https://crrev.com/55d4c7aa6b0e5bb284e48526d410a489b7ed36e1/chrome/browser/flag-metadata.json

Status: Fixed (was: Assigned)
Labels: CommitLog-Audit-Violation Merge-Without-Approval
Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 55d4c7aa6b0e5bb284e48526d410a489b7ed36e1 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 
Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/55d4c7aa6b0e5bb284e48526d410a489b7ed36e1

Commit: 55d4c7aa6b0e5bb284e48526d410a489b7ed36e1
Author: joelhockey@chromium.org
Commiter: joelhockey@chromium.org
Date: 2018-12-10 08:27:33 +0000 UTC

FilesApp crostini: make crostini-files flag visible to users

The flag was inadvertently removed when making the feature
disabled by default for M72 in crosreview.com/1362010

Flag changed from 'disable-crostini-files' to 'crostini-files'

Bug:  913175 
Bug: 889261
Change-Id: If5a8a79de941612a9f8a274b2702a032d4f1fa25
Reviewed-on: https://chromium-review.googlesource.com/c/1368847
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#615010}(cherry picked from commit 39d4a75a1ef2eb572a779f36c6f1f0a11be86d75)
Reviewed-on: https://chromium-review.googlesource.com/c/1368851
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#174}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment