New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment
link

Issue 913171: Recent third_party/dawn autoroll cause Deterministic Linux Trybot failure

Reported by hua...@chromium.org, Dec 8 Project Member

Issue description

third_party/dawn had an auto roll recently:

  https://chromium-review.googlesource.com/c/chromium/src/+/1368493

Thereafter bots "Deterministic Linux" and 'Deterministic Linux (dbg)" have been consistently failing; example:

  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux%20%28dbg%29?limit=200

with error "Failure generate .isolate files."

Worse, there is some hysteresis to the bug: If "gn gen" works before the change, then it continues working after the change, until "gn clean" gets called!

******** Steps to repro on Linux ******** 

# Create out/Release.2, and create minimal args.gn. Example:
mkdir out/Release.2
echo 'target_os = "linux"' > out/Release.2/args.gn

# Things should work for the CL before.
git checkout fcb0b894cc0a8ca3d311292018e22a99fe39d723~1
gclient sync
gn gen out/Release.2
gn clean out/Release.2
python -u ./tools/mb/mb.py isolate-everything -m chromium.linux -b 'Deterministic Linux (dbg)' --config-file ./tools/mb/mb_config.pyl out/Release.2

# Now apply the auto-roll, and clean everything.
git checkout fcb0b894cc0a8ca3d311292018e22a99fe39d723
gclient sync
gn gen out/Release.2
gn clean out/Release.2
python -u ./tools/mb/mb.py isolate-everything -m chromium.linux -b 'Deterministic Linux (dbg)' --config-file ./tools/mb/mb_config.pyl out/Release.2


### This results in the following failure ###

...
Done. Made 11684 targets from 1874 files in 3871ms
Traceback (most recent call last):
  File "./tools/mb/mb.py", line 63, in Main
    ret = self.args.func()
  File "./tools/mb/mb.py", line 313, in CmdIsolateEverything
    return self.RunGNGenAllIsolates(vals)
  File "./tools/mb/mb.py", line 854, in RunGNGenAllIsolates
    return self.GenerateIsolates(vals, isolate_targets, isolate_map, build_dir)
  File "./tools/mb/mb.py", line 916, in GenerateIsolates
    ', '.join(runtime_deps_targets))
MBErr: did not generate any of dawn_end2end_tests.runtime_deps
 

Comment 1 by hua...@chromium.org, Dec 8

Cc: mamir@chromium.org szager@chromium.org yhirano@chromium.org ramyan@chromium.org
Owner: cwallez@chromium.org
(CC other sheriffs).

cwallez@: There's some problem with dawn_end2end_tests.runtime_deps. Please fix this before rolling dawn again. Thanks!

Comment 2 by hua...@chromium.org, Dec 8

Status: Assigned (was: Untriaged)

Comment 3 by hua...@chromium.org, Dec 8

Description: Show this description

Comment 4 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://dawn.googlesource.com/dawn/+/07df605a2bfb4f27f96968ac36bf94636af17fb3

commit 07df605a2bfb4f27f96968ac36bf94636af17fb3
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Dec 10 16:45:24 2018

BUILD.gn: Add temporary proxy groups for test targets

This will allow use to update gn_isolate_map_pyl to point to the groups
instead of the targets, while we move the actual targets in a different
file.

BUG= chromium:913171 

Change-Id: Ic681fb12d9cbc99557b742784f5b1bf779b76ed1
Reviewed-on: https://dawn-review.googlesource.com/c/3100
Reviewed-by: Stephen White <senorblanco@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/07df605a2bfb4f27f96968ac36bf94636af17fb3/BUILD.gn

Comment 5 by bugdroid1@chromium.org, Dec 10

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/318899bf06319dedb69eca77fabadc6a6f578859

commit 318899bf06319dedb69eca77fabadc6a6f578859
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Dec 10 18:30:52 2018

Roll src/third_party/dawn c3ecb5a77c06..07df605a2bfb (1 commits)

https://dawn.googlesource.com/dawn.git/+log/c3ecb5a77c06..07df605a2bfb


git log c3ecb5a77c06..07df605a2bfb --date=short --no-merges --format='%ad %ae %s'
2018-12-10 cwallez@chromium.org BUILD.gn: Add temporary proxy groups for test targets


Created with:
  gclient setdep -r src/third_party/dawn@07df605a2bfb

The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:913171 
TBR=cwallez@chromium.org

Change-Id: I6c678837c03378fbf17e0deaab113b3813da67a9
Reviewed-on: https://chromium-review.googlesource.com/c/1370068
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#615177}
[modify] https://crrev.com/318899bf06319dedb69eca77fabadc6a6f578859/DEPS

Comment 6 by cwallez@chromium.org, Dec 14

Status: Fixed (was: Assigned)

Sign in to add a comment