New issue
Advanced search Search tips

Issue 913168 link

Starred by 1 user
Status: Verified
Owner:
sergeyu@chromium.org
Closed: Dec 11
Cc:
kmarshall@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

NetworkChangeNotifierFuchsiaTest.* tests failing due to SDK roll

Project Member Reported by wez@google.com, Dec 8 
In https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-rel/6393 these tests started failing due to FIDL serialization issue:

[ RUN      ] NetworkChangeNotifierFuchsiaTest.SecondaryInterfaceDeletedNoop
fidl encoding error at ../../third_party/fuchsia-sdk/sdk/pkg/fidl_cpp/internal/pending_response.cc:69: Tried to decode a bad union discriminant, type fuchsia.netstack/NetstackGetInterfacesResponse, 304 bytes, 0 handles

Assigning to kmarshall@ as the next Gardener.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a3b84d7f61655374944b627bd1e1cdc3a4f0804

commit 6a3b84d7f61655374944b627bd1e1cdc3a4f0804
Author: Wez <wez@chromium.org>
Date: Sat Dec 08 22:59:57 2018

Revert "Roll Fuchsia SDK from 9d623aaaba71 to 24fe9b091958"

This reverts commit e45b23b94c134967ecd936c90b38bd7bdf80eac6.

Reason for revert: Appears to have broken the NetworkChangeNotifierFuchsia (see https://bugs.chromium.org/p/chromium/issues/detail?id=913168).

Original change's description:
> Roll Fuchsia SDK from 9d623aaaba71 to 24fe9b091958
> 
> Also includes minor changes in //net to account for changes in
> fuchsia.netstack API.
> 
> TBR=fdegans@chromium.org
> 
> Change-Id: I40ada5f116f491d05a3ae2f21d052dc4ed9ce735
> Reviewed-on: https://chromium-review.googlesource.com/c/1366815
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614891}

TBR=sergeyu@chromium.org,fdegans@chromium.org

Bug:  913168 
Change-Id: I10080c58f4ac2d6bba9a1006550d19310b66c6e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1369223
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614982}
[modify] https://crrev.com/6a3b84d7f61655374944b627bd1e1cdc3a4f0804/build/fuchsia/linux.sdk.sha1
[modify] https://crrev.com/6a3b84d7f61655374944b627bd1e1cdc3a4f0804/build/fuchsia/mac.sdk.sha1
[modify] https://crrev.com/6a3b84d7f61655374944b627bd1e1cdc3a4f0804/net/base/network_change_notifier_fuchsia.cc
[modify] https://crrev.com/6a3b84d7f61655374944b627bd1e1cdc3a4f0804/net/base/network_change_notifier_fuchsia_unittest.cc
[modify] https://crrev.com/6a3b84d7f61655374944b627bd1e1cdc3a4f0804/net/base/network_interfaces_fuchsia.cc
[modify] https://crrev.com/6a3b84d7f61655374944b627bd1e1cdc3a4f0804/net/base/network_interfaces_fuchsia.h

Comment 2 by wez@google.com, Dec 8

Cc: sergeyu@chromium.org

Comment 3 by w...@chromium.org, Dec 9

Cc: -sergeyu@chromium.org kmarshall@chromium.org
Owner: sergeyu@chromium.org

Comment 4 by kmarshall@chromium.org, Dec 11

Status: Verified (was: Assigned)
Fixed by https://chromium-review.googlesource.com/c/1370487 .
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://skia.googlesource.com/buildbot/+/e9c7063e93db6d5a5bd5a278a6fdb8eac665cfe2

commit e9c7063e93db6d5a5bd5a278a6fdb8eac665cfe2
Author: Aidan Wolter <awolter@chromium.org>
Date: Tue Dec 11 22:30:07 2018

Migrate Fuchsia SDK to fuchsia/sdk/core

Bug:  913168 
Test: None
Change-Id: I52b2c3b73fd2614e13ee7b5fbdf6e58a3c1c2ad5
Reviewed-on: https://skia-review.googlesource.com/c/176384
Commit-Queue: Eric Boren <borenet@google.com>
Reviewed-by: Wez <wez@chromium.org>

[modify] https://crrev.com/e9c7063e93db6d5a5bd5a278a6fdb8eac665cfe2/autoroll/go/repo_manager/fuchsia_sdk_repo_manager_test.go
[modify] https://crrev.com/e9c7063e93db6d5a5bd5a278a6fdb8eac665cfe2/autoroll/go/repo_manager/fuchsia_sdk_repo_manager.go
►

Sign in to add a comment