iannucci@: The aggregated failure isn't derived from InfraFailure, and the engine doesn't know how to inspect inside an aggregated failure. See bottom of https://bugs.chromium.org/p/chromium/issues/detail?id=897633 for more context.
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/recipes-py/+/3f3879c37865ac94e52e8d91a70399ca37ae4fb8 commit 3f3879c37865ac94e52e8d91a70399ca37ae4fb8 Author: Joshua Seaton <joshuaseaton@google.com> Date: Tue Dec 18 22:20:20 2018 Make aggregated InfraFailures surface as exceptions. Today, AggregatedStepFailures are handled only as StepFailures. This change ensures that when an AggregatedStepFailure contains an InfraFailure it is handled like one. Bug: 913157 Change-Id: I3df5f79add19af1f345822c83f1ab883307aeb22 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: depot_tools Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/c/1378798 Commit-Queue: Joshua Seaton <joshuaseaton@google.com> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> [modify] https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8/recipe_modules/step/examples/full.expected/basic.json [modify] https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8/recipe_modules/step/examples/full.py [modify] https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8/recipe_modules/step/examples/full.expected/infra_failure.json [modify] https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8/recipe_modules/step/examples/full.expected/invalid_access.json [add] https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8/recipe_modules/step/examples/full.expected/defer_results_with_infra_failure.json [modify] https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8/recipe_modules/step/tests/defer.expected/one_fail.json [modify] https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8/README.recipes.md [modify] https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8/recipe_engine/run.py [modify] https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8/recipe_modules/step/examples/full.expected/defer_results.json [modify] https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8/recipe_engine/recipe_api.py
Verified: https://ci.chromium.org/p/fuchsia/builders/luci.fuchsia.try/topaz-x64-release/b8926575089649098608
Comment 1 by joshuaseaton@google.com
, Dec 15Status: Started (was: Untriaged)