New issue
Advanced search Search tips

Issue 913155 link

Starred by 1 user
Status: Duplicate
Merged: issue 829650
Owner:
w...@chromium.org
Closed: Dec 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

Some NetworkErrorLoggingEndToEndTest.* tests hang under Fuchsia

Project Member Reported by w...@chromium.org, Dec 8 
We observe NetworkErrorLoggingEndToEndTest.UploadAtShutdown e.g. in
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-rel/6355
and
NetworkErrorLoggingEndToEndTest.ReportNetworkError e.g. in
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-fyi-x64-rel/6356
failing, seemingly having hung.

Log output for the individual tests doesn't really give any clues as to the trigger.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce988da67294d10b86ecd030bbb54c2be40a3061

commit ce988da67294d10b86ecd030bbb54c2be40a3061
Author: Wez <wez@chromium.org>
Date: Sat Dec 08 01:50:10 2018

[Fuchsia] Filter some more flaking net_unittests.

Bug:  913155 ,  913156 
Change-Id: If5804fb6c8b035a7d220e8eb629f0d6c05a90e0d
Reviewed-on: https://chromium-review.googlesource.com/c/1369044
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614908}
[modify] https://crrev.com/ce988da67294d10b86ecd030bbb54c2be40a3061/testing/buildbot/filters/fuchsia.net_unittests.filter

Comment 2 by w...@chromium.org, Dec 11

Mergedinto: 829650
Status: Duplicate (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d377ecc5c538b5e5b2d227158f1d3a9665789c87

commit d377ecc5c538b5e5b2d227158f1d3a9665789c87
Author: Wez <wez@chromium.org>
Date: Tue Dec 11 19:05:56 2018

Revert "[Fuchsia] Filter some more flaking net_unittests."

This reverts commit ce988da67294d10b86ecd030bbb54c2be40a3061.

Reason for revert: SpawnTestServer issue continues, but now affects different tests, suggesting that this is an issue with some earlier/parallel test e.g. leaking a TestServer instance, rather than an issue with the tests that flake as a result.

Original change's description:
> [Fuchsia] Filter some more flaking net_unittests.
> 
> Bug:  913155 ,  913156 
> Change-Id: If5804fb6c8b035a7d220e8eb629f0d6c05a90e0d
> Reviewed-on: https://chromium-review.googlesource.com/c/1369044
> Commit-Queue: Wez <wez@chromium.org>
> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#614908}

TBR=wez@chromium.org,fdegans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  913155 ,  913156 
Change-Id: I9af3748ebfab26a67f77faf011b7bea526e6a93d
Reviewed-on: https://chromium-review.googlesource.com/c/1372315
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615614}
[modify] https://crrev.com/d377ecc5c538b5e5b2d227158f1d3a9665789c87/testing/buildbot/filters/fuchsia.net_unittests.filter
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3b8e8bea9846a5c3a2c06d8e8ef4893550a7188

commit a3b8e8bea9846a5c3a2c06d8e8ef4893550a7188
Author: Wez <wez@chromium.org>
Date: Tue Dec 11 20:17:10 2018

Disable flaky NetworkErrorLoggingEndToEndTests under OS_FUCHSIA.

These tests are already disabled under OS_WIN, so just add OS_FUCHSIA to
the preprocessor condition.

Bug: 829650,  913155 
Change-Id: I6b323a1918e655d890715ae331fae4e612d5228c
Reviewed-on: https://chromium-review.googlesource.com/c/1372323
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615641}
[modify] https://crrev.com/a3b8e8bea9846a5c3a2c06d8e8ef4893550a7188/net/network_error_logging/network_error_logging_end_to_end_test.cc
►

Sign in to add a comment