[Merge Request M72] Fix issue in migration dialog |
||||
Issue descriptionRequest to merge CL https://chromium-review.googlesource.com/c/chromium/src/+/1359752. It makes the migration dialog block the whole browser when it is visible, which is consistent with other modal dialog. It also fixes the problem that leads browser to crash if closing browser when the dialog is visible. Have tested in Canary 73.0.3633.0. Please see the screen recording. Note on mac the browser cannot be closed when the dialog is visible (WAI), but it indicates the crash is fixed. The feature is part of the Paradise project and is thus controlled by project's Finch flag. No other project/feature touches this file. Thanks!
,
Dec 10
Merged as https://chromium-review.googlesource.com/c/chromium/src/+/1370825; marking as Fixed.
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b925cbeea5a4d0855aeda617b79abe064acf8937 commit b925cbeea5a4d0855aeda617b79abe064acf8937 Author: siyua <siyua@chromium.org> Date: Mon Dec 10 21:01:09 2018 [AF Paradise] Fix issue in migration dialog 1) Make the error dialog block browser, which is consistent with other dialogs. 2) Override Close() function since otherwise if user close browser when dialog is visible, the default Close() will call Cancel(). Bug: 913154 Change-Id: I2e0c92621ae04ce34a212dabcf69be2cad99bdf8 Reviewed-on: https://chromium-review.googlesource.com/c/1359752 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614268}(cherry picked from commit 2596ec460ffe11900b95ca0718b53682fb806525) Reviewed-on: https://chromium-review.googlesource.com/c/1370825 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3626@{#235} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/b925cbeea5a4d0855aeda617b79abe064acf8937/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc [modify] https://crrev.com/b925cbeea5a4d0855aeda617b79abe064acf8937/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h [modify] https://crrev.com/b925cbeea5a4d0855aeda617b79abe064acf8937/chrome/browser/ui/views/autofill/local_card_migration_error_dialog_view.cc [modify] https://crrev.com/b925cbeea5a4d0855aeda617b79abe064acf8937/chrome/browser/ui/views/autofill/local_card_migration_error_dialog_view.h
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b925cbeea5a4d0855aeda617b79abe064acf8937 Commit: b925cbeea5a4d0855aeda617b79abe064acf8937 Author: siyua@chromium.org Commiter: jsaul@google.com Date: 2018-12-10 21:01:09 +0000 UTC [AF Paradise] Fix issue in migration dialog 1) Make the error dialog block browser, which is consistent with other dialogs. 2) Override Close() function since otherwise if user close browser when dialog is visible, the default Close() will call Cancel(). Bug: 913154 Change-Id: I2e0c92621ae04ce34a212dabcf69be2cad99bdf8 Reviewed-on: https://chromium-review.googlesource.com/c/1359752 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614268}(cherry picked from commit 2596ec460ffe11900b95ca0718b53682fb806525) Reviewed-on: https://chromium-review.googlesource.com/c/1370825 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3626@{#235} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
||||
►
Sign in to add a comment |
||||
Comment 1 by sheriffbot@chromium.org
, Dec 9