New issue
Advanced search Search tips

Issue 913150 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[Merge Request M72] Offer users an option to delete card from local if uploading failed

Project Member Reported by siyua@chromium.org, Dec 8

Issue description

Request to merge CL https://chromium-review.googlesource.com/c/chromium/src/+/1314129.

It allows users to delete uploading failed card from local storage, which is an important part of the migration feedback.

Have tested successfully in 73.0.3633.0. Please see the screen recording. 

The feature is part of the Paradise project and is thus controlled by project's Finch flag. No other project/feature touches this file.

Thanks! 
 
DeleteCard.mov
9.4 MB View Download
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 9

Labels: -Merge-Request-72 Hotlist-Merge-Approved Merge-Approved-72
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 10

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab

commit bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab
Author: Jared Saul <jsaul@google.com>
Date: Mon Dec 10 20:55:46 2018

Offer users an option to delete card from local if uploading failed

If uploading of a card failed, in the feedback dialog, we will show
a string 'invalid' and a trash can button. If the user clicks the button,
that card will be deleted from browser and will disappear in the
feedback dialog. If all invalid cards are deleted in the dialog, the
dialog will be updated to the 'finished' state.

If all cards failed, we will not show the "View cards button".

Uploaded screenshots in the bug (comment #10 and comment #26).

Using TBR because this merge had a conflict and needed to fix manually:
TBR=estade@chromium.org,tobiasjs@chromium.org,bsep@chromium.org,mahmadi@chromium.org

(cherry picked from commit 26874dced3505ab4577ca03215e59cb042a01c58)

Bug:  913150 
Change-Id: Iae7780027932ac530bcb2f0c643be1ec94d1f334
Reviewed-on: https://chromium-review.googlesource.com/c/1314129
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614193}
Reviewed-on: https://chromium-review.googlesource.com/c/1369941
Cr-Commit-Position: refs/branch-heads/3626@{#234}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/android_webview/browser/aw_autofill_client.cc
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/android_webview/browser/aw_autofill_client.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/chrome/browser/ui/autofill/chrome_autofill_client.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.cc
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/chrome/browser/ui/autofill/manage_migration_ui_controller.cc
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/chrome/browser/ui/autofill/manage_migration_ui_controller.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/chrome/browser/ui/views/autofill/migratable_card_view.cc
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/chrome/browser/ui/views/autofill/migratable_card_view.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill/core/browser/autofill_client.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill/core/browser/local_card_migration_manager.cc
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill/core/browser/local_card_migration_manager.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill/core/browser/local_card_migration_manager_unittest.cc
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill/core/browser/test_autofill_client.cc
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill/core/browser/test_autofill_client.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill/core/browser/ui/local_card_migration_dialog_controller.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill_strings.grdp
[add] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill_strings_grdp/IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_LABEL_INVALID_CARDS.png.sha1
[add] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill_strings_grdp/IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_MESSAGE_INVALID_CARD_REMOVED.png.sha1
[add] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/components/autofill_strings_grdp/IDS_AUTOFILL_LOCAL_CARD_MIGRATION_DIALOG_TRASH_CAN_BUTTON_TOOLTIP.png.sha1
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/ios/web_view/internal/autofill/web_view_autofill_client_ios.h
[modify] https://crrev.com/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab/ios/web_view/internal/autofill/web_view_autofill_client_ios.mm

Status: Fixed (was: Assigned)
Merged as https://chromium-review.googlesource.com/c/chromium/src/+/1369941, marking as Fixed.

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab

Commit: bbb07a2bed8601c809fbaa4ed7447d7ed5de17ab
Author: jsaul@google.com
Commiter: jsaul@google.com
Date: 2018-12-10 20:55:46 +0000 UTC

Offer users an option to delete card from local if uploading failed

If uploading of a card failed, in the feedback dialog, we will show
a string 'invalid' and a trash can button. If the user clicks the button,
that card will be deleted from browser and will disappear in the
feedback dialog. If all invalid cards are deleted in the dialog, the
dialog will be updated to the 'finished' state.

If all cards failed, we will not show the "View cards button".

Uploaded screenshots in the bug (comment #10 and comment #26).

Using TBR because this merge had a conflict and needed to fix manually:
TBR=estade@chromium.org,tobiasjs@chromium.org,bsep@chromium.org,mahmadi@chromium.org

(cherry picked from commit 26874dced3505ab4577ca03215e59cb042a01c58)

Bug:  913150 
Change-Id: Iae7780027932ac530bcb2f0c643be1ec94d1f334
Reviewed-on: https://chromium-review.googlesource.com/c/1314129
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Siyu An <siyua@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#614193}
Reviewed-on: https://chromium-review.googlesource.com/c/1369941
Cr-Commit-Position: refs/branch-heads/3626@{#234}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment