Issue 913141 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	lijeffrey@chromium.org
Closed:	Dec 13
Cc:	█ robert...@chromium.org chanli@chromium.org lijeffrey@chromium.org liaoyuke@chromium.org st...@chromium.org
Components:	Tools>Test>FindIt>Flakiness
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	1
Type:	Bug

[Findit] Flake Issue to store issue labels instead of priority

Project Member Reported by lijeffrey@chromium.org, Dec 7

Issue description

FlakeIssue has a priority property which is an integer. However these are stored as strings within the list of labels in monorail as 'Pri-1' etc.

Store labels instead of priority outright and extract priority from label.

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 10

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/09ac7002ee3a499022bdfc1fe36c89bc34f99a94

commit 09ac7002ee3a499022bdfc1fe36c89bc34f99a94
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Dec 10 19:07:32 2018

[Findit] Set labels instead of priority for FlakeIssue

Bug:  913141 
Change-Id: I9a633092be998ee83af4afc1d18d3c6db629b3bb
Reviewed-on: https://chromium-review.googlesource.com/c/1368498
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19452}
[modify] https://crrev.com/09ac7002ee3a499022bdfc1fe36c89bc34f99a94/appengine/findit/model/flake/test/flake_issue_test.py
[modify] https://crrev.com/09ac7002ee3a499022bdfc1fe36c89bc34f99a94/appengine/findit/model/flake/flake_issue.py
[modify] https://crrev.com/09ac7002ee3a499022bdfc1fe36c89bc34f99a94/appengine/findit/handlers/flake/detection/test/show_flake_test.py
[modify] https://crrev.com/09ac7002ee3a499022bdfc1fe36c89bc34f99a94/appengine/findit/handlers/flake/detection/test/flake_detection_utils_test.py

Comment 2 by lijeffrey@chromium.org, Dec 13

Status: Fixed (was: Untriaged)

►

Issue 913141 link

Issue metadata

[Findit] Flake Issue to store issue labels instead of priority

Issue description

Comment 1 by bugdroid1@chromium.org, Dec 10

Comment 1 Deleted

Comment 2 by lijeffrey@chromium.org, Dec 13

Comment 2 Deleted

Sign in to add a comment