Direct composition video pixel tests are flaky on Nvidia Windows |
|||
Issue descriptionSee for example: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/145782 This was for a CL trying to re-enable the pixel tests: https://chromium-review.googlesource.com/c/chromium/src/+/1214364 This shows the images (diff is broken but you can use imagemagick locally and see the difference): http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?14e2ef4bd1a4b9c599cbbf1b9264612caf547423_win7_chromium_rel_ng_telemetry These tests enable direct composition video swap chains with --enable-direct-composition-layers which is not a code path we ship to users except for the software protected video experiment
,
Dec 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b188cd82b0f877078b2a7f87169a4a16a1f9507d commit b188cd82b0f877078b2a7f87169a4a16a1f9507d Author: Jamie Madill <jmadill@chromium.org> Date: Tue Dec 11 16:38:53 2018 Revert "Re-enable video pixel tests after rebaselining" This reverts commit 1a9264ddffb97e645ae936840846a741dfefee24. Reason for revert: rebaseline didn't seem to work. Failing builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/3655 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28NVIDIA%29/3470 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28Intel%20HD%20630%29/2954 Failing tests: gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_VP9 gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_VP9 gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_MP4 gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_MP4 Original change's description: > Re-enable video pixel tests after rebaselining > > The tests were marked as failing and version numbers were incremented in > https://crrev.com/c/1182222, but I forgot to re-enable the tests. > > Bug: 869677, 913138, 858826, 819635, 774809 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I7fdb28c3dbaa7aad4137b16d8f9bf8fe15fe9a08 > Reviewed-on: https://chromium-review.googlesource.com/c/1214364 > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615353} TBR=kbr@chromium.org,sunnyps@chromium.org Change-Id: I553c10ca8022a90a0afa73ffafa44aa5bbf4e2d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869677, 913138, 858826, 819635, 774809 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1372234 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#615553} [modify] https://crrev.com/b188cd82b0f877078b2a7f87169a4a16a1f9507d/content/test/gpu/gpu_tests/pixel_expectations.py
,
Dec 14
GPU Triage: zmo@ could you please triage? Should this be just marked available?
,
Dec 14
Per discussion with kbr@, let's update the revision numbers of these tests, allow the new reference images to be generated on these bots, and then give it another try to enable the tests. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Dec 11